Identity Provider: provide response to aragonAPI when user cancels identity modification #686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…entity modification
sohkai
commented
Apr 9, 2019
| this.setState({ identityIntent: null }, identityIntent.resolve) | ||
| ) | ||
| .then(identityIntent.resolve) | ||
| .then(() => this.setState({ identityIntent: null })) |
There was a problem hiding this comment.
I think it's more clear this way (it also propagates the returned metadata to requestAddressIdentityModification()), but perhaps there was a reason for doing the resolution in the setState() callback?
There was a problem hiding this comment.
I agree. I don't believe there was a reason.
2color
approved these changes
Apr 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Coupled with aragon/aragon.js#277, apps will now receive errors on
requestAddressIdentityModification().