Skip to content
This repository has been archived by the owner on May 21, 2019. It is now read-only.

Permissions app #6

Closed
jounih opened this issue Jul 22, 2018 · 6 comments
Closed

Permissions app #6

jounih opened this issue Jul 22, 2018 · 6 comments

Comments

@jounih
Copy link
Contributor

jounih commented Jul 22, 2018

The purpose of permissions app is to let users of a DAO view and manage permissions between users, apps and groups.

The permissions app allows many types of DAOs to be constructed via a visual interface.

Example 1: Allow Voting app (ie. token holder vote) to execute actions in another app - for instance minting new tokens in the Tokens app, or transferring tokens in the Finance app.

Example 2: Allow a token holder, or a group of token holders privileged access to certain app or apps.

TODO:

-Nested permissions (a DAO having permissions in another DAO)
-Constraints (for example, permission for only allowing transfer of < n tokens in n timeframe)

Clickthrough prototype:

https://invis.io/ENN3K3FR6Z4

Design:

webapp-1366px - permissions 2x

webapp-1366px - permissions app instance 2x

webapp-1366px - permissions add permission entity filled 2x

webapp-1366px - permissions app instance pending 2x

webapp-1366px - permissions modify permission 2x

webapp-1366px - permissions entity details 2x

@luisivan
Copy link

luisivan commented Jul 23, 2018

Feedback:

  • Looks amazing
  • On Browse by entity in the main screen, Type should just be Entity, as we cannot determine if it's a User or any Contract. Also, I'd encourage to unify apps inside the Entity component, so an app would be displayed with its icon and its name, and maybe a tag specifying that it is an app. This way we have a component reusable everywhere, and we could also remove the Type column

@stellarmagnet
Copy link

stellarmagnet commented Jul 29, 2018

Question:

One example is that in this design you see "ASSIGN_ROLE" mapped to a human-readable "Assign tokens".

Where is the human readable definition of a Permission managed?

How does one update the human readable name of the Permission (I imagine people may think of better terminology over time to describe the role, that may not have been obvious at time of app deployment).

@luisivan
Copy link

Do you mean of a Permission Manager?

As for how to describe those, it'd be here https://hack.aragon.org/docs/tutorial.html#writing-the-manifest-files

@sohkai
Copy link

sohkai commented Jul 31, 2018

@jounih Pierre and I had a conversation today about getting data into the app and clarifying how everything works under the hood. The implementation's shaping up nicely!

I've added a few comments to the Invision based on notes from our conversation.

One of the major topics we touched upon was the creation of the first permission, since this is a special action that both requires more information, as well as access to a special role. We're thinking of designing a separate page in the app for this particular action, to give more information and help users understand the importance of who they choose to be the permission's "manager".

@lyricalpolymath
Copy link

yes agreed with @stellarmagnet on adding human readable description to the action
the current action "description" is more of a title
a good description would have:

  • a more verbose explanation of what the action does, explaining the parameters in more details
  • a description on the consequences or ramifications of changing the properties of this action

eg in this case it would be useful to explain the "period" of what? of accounting?
I was for instance trying to set a daily limit in the multisig (which I might be misinterpreting as being the Finance app) and this was the only "option" or "action" that seemed relevant (but probably isn't)

thinking this
I sense that there is missing a "settings" page for each app whereas the user can

  • SETTINGS: change the parameters/settings (variables that have setters or are public)
  • PERMISSIONS: change who can change these parameters (permissions that represents solidity function modifiers)

just some ideas while playing with your awesome software 😄

screen shot 2018-11-16 at 18 08 01

@sohkai
Copy link

sohkai commented Nov 18, 2018

@lyricalpolymath I've created aragon/client#486 to discuss, since the design in this particular issue has been implemented.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

7 participants