-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Core: Registry proposal #214
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My current mental model of Govern is a bit unclear with the current changes. I think we still need to give more definition to what we consider it is a DAO in the context of Govern.
From the current changes it's clear that:
- A DAO will be the owner of several registration entities identified by a unique name.
- Those entities are the links between an executor and a queue.
- A DAO has metadata and an owner
It's unclear to me:
- What's the difference between a DAO and an executor instance.
- What's the relation between register a pair (executor, queue) and assign it an owner.
- What happened if a pair has no owner.
@@ -36,4 +35,11 @@ contract GovernRegistry is IERC3000Registry { | |||
function _setMetadata(IERC3000Executor _executor, bytes memory _metadata) internal { | |||
emit SetMetadata(_executor, _metadata); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe now the metadata should be related to the owner address instead of the executor?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup, agreed. I thought already before it is strange that anyone can change the metadata of a registered Executor
.
Some really good points! Do we want to have a call with @izqui to discuss them first before we focus more on the code? |
@nivida what's the status of this? |
@izqui We decided back then to organize a call with you to discuss it closer. I will introduce the new devs to Govern and will definitely come back to you in case we have a call about it or any other kind of communication we would like to hear your feedback. Thanks for asking back! |
I've created quickly a draft implementation of the solution I thought could work for the new
GovernRegistry
. Would be great to get some feedback here and to start the discussion about.closes #196