Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Govern JS Client #77

Merged
merged 86 commits into from
Oct 30, 2020
Merged

Govern JS Client #77

merged 86 commits into from
Oct 30, 2020

Conversation

nivida
Copy link
Contributor

@nivida nivida commented Oct 21, 2020

This PR implements the current Govern Server API.

I have switched it to ready for review but the API queries need to be adjusted and tested as soon as the Govern server API has updated

closes #75

@CLAassistant
Copy link

CLAassistant commented Oct 21, 2020

CLA assistant check
All committers have signed the CLA.

@nivida nivida added P2 👀 'Lets do!' issues S1: Feature 👨‍🎨 Adding new stuff T2: DX 👷‍♀️ Developer experience issues labels Oct 21, 2020
@bpierre bpierre mentioned this pull request Oct 21, 2020
@nivida nivida marked this pull request as ready for review October 29, 2020 08:20
@nivida nivida moved this from In progress to Review in progress in Aragon Govern v1.0 Oct 29, 2020
Copy link
Contributor

@bpierre bpierre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (G as in great)

docs/developers/govern-js.md Show resolved Hide resolved
packages/govern/README.md Outdated Show resolved Hide resolved
Aragon Govern v1.0 automation moved this from Review in progress to Reviewer approved Oct 30, 2020
@nivida nivida merged commit 1af0c52 into master Oct 30, 2020
Aragon Govern v1.0 automation moved this from Reviewer approved to Done Oct 30, 2020
@nivida nivida deleted the govern-js-client branch October 30, 2020 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P2 👀 'Lets do!' issues S1: Feature 👨‍🎨 Adding new stuff T2: DX 👷‍♀️ Developer experience issues
Projects
Development

Successfully merging this pull request may close these issues.

Govern.js
4 participants