erc3k: update interface id #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #80 +/- ##
==========================================
+ Coverage 21.48% 22.58% +1.09%
==========================================
Files 3 3
Lines 121 124 +3
Branches 13 14 +1
==========================================
+ Hits 26 28 +2
- Misses 95 96 +1
Continue to review full report at Codecov.
|
Evalir
approved these changes
Oct 21, 2020
| @@ -90,7 +97,7 @@ task('deploy-govern', 'Deploys an Govern from provided factory') | |||
| factoryAddr | |||
| ) | |||
| const tx = await GovernBaseFactory.newDummyGovern(name, { | |||
| gasLimit: 3500000, | |||
| gasLimit: 4000000, | |||
There was a problem hiding this comment.
Interesting; did the gas requirements for deploying a DAO go up?
There was a problem hiding this comment.
This is for deploying the Govern Factory so we are fine. But with the previous value was reverted
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the
ERC3000_INTERFACE_IDafter the changes to theIERC3000