Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(sdk): add getProtocolVersion function #76

Merged
merged 12 commits into from
Apr 22, 2024
Merged

feat(sdk): add getProtocolVersion function #76

merged 12 commits into from
Apr 22, 2024

Conversation

josemarinas
Copy link
Contributor

@josemarinas josemarinas commented Apr 19, 2024 •
edited
Loading

Description

Add a getProtocolVersion function that returns the protocol version of a contract. If the contract implements the protocolVersion function it will return the protocol version if not it will always return [1,0,0]

The function receives an url and a contract address. Internally works with ethers but externally is agnostic

Task ID: OS-1025

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I created tasks to update dependent repositories (OSx, Plugins)
  • I ran all tests with success and extended them if necessary.
  • I have updated the CHANGELOG.md file in the root folder.

@github-actions github-actions bot added the sdk label Apr 19, 2024
banasa44
banasa44 reviewed Apr 19, 2024
View reviewed changes
sdk/src/introspection.ts Outdated Show resolved Hide resolved
@josemarinas @banasa44
Update sdk/src/introspection.ts
3491c53 
Co-authored-by: Carles <75954325+banasa44@users.noreply.github.com>
heueristik
heueristik reviewed Apr 22, 2024
View reviewed changes
Copy link
Contributor

@heueristik heueristik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've left some minor comments

josemarinas and others added 5 commits April 22, 2024 11:15
@josemarinas @heueristik
Update sdk/src/introspection.ts
ce09f98 
Co-authored-by: Michael Heuer <20623991+Michael-A-Heuer@users.noreply.github.com>
@josemarinas @heueristik
Update sdk/test/unit/introspection.test.ts
fa1c70d 
Co-authored-by: Michael Heuer <20623991+Michael-A-Heuer@users.noreply.github.com>
@josemarinas
remove: constant ADDRESS_ONE
43efc4c
@josemarinas
fix: prettier
0fb3f41
@josemarinas
update: changelog and package version
5a8e518
heueristik
heueristik previously approved these changes Apr 22, 2024
View reviewed changes
Copy link
Contributor

@heueristik heueristik left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - make sure to add a good PR title and the sdk-release label (and to tick the checklist items that apply)

@josemarinas josemarinas changed the title F/os 1025 add get protocol version feat(sdk): add getProtocolVersion function Apr 22, 2024
@heueristik heueristik changed the title feat(sdk): add getProtocolVersion function feat(sdk): add getProtocolVersion function Apr 22, 2024
clauBv23
clauBv23 reviewed Apr 22, 2024
View reviewed changes
sdk/src/introspection.ts Outdated Show resolved Hide resolved
sdk/src/introspection.ts Show resolved Hide resolved
sdk/test/unit/introspection.test.ts Outdated Show resolved Hide resolved
@josemarinas josemarinas merged commit b3bd6da into develop Apr 22, 2024
5 checks passed
@josemarinas josemarinas deleted the f/OS-1025-add-get-protocol-version branch April 22, 2024 14:38
@heueristik heueristik mentioned this pull request Apr 22, 2024
Merged
heueristik added a commit that referenced this pull request Apr 29, 2024
@heueristik @Rekard0
@mathewmeconry @josemarinas @clauBv23 @jordaniza @banasa44
chore: merge develop into main (#75)
7df1629 
* setup repo with subgraph

* add pull request template

* add empty lines

* re-structure the folders

* add plugin repos ids

* re org the folder structure

* chore: moves pull request template to correct location (#2)

* add plugin, setup, & plugin permission ids

* F OS-601 Add subgraph tests (#4)

* add subgraph tests

* Update subgraph/subgraph.yaml

Co-authored-by: Rekard0 <5880388+Rekard0@users.noreply.github.com>

* Update subgraph/schema.graphql

Co-authored-by: Rekard0 <5880388+Rekard0@users.noreply.github.com>

---------

Co-authored-by: Rekard0 <5880388+Rekard0@users.noreply.github.com>

* refactor

* Add test for pluginRepo

* yarn subgraph test workflow

* remove cache yarn

* refactor outputs

* add comment

* abstract permissions

* update change log

* add security contact to the readmes

* Update subgraph/src/ids/permissions.ts

Co-authored-by: Mathias Scherer <scherer.mat@gmail.com>

* adapt id and test to osx update

* update changelog

* organize permission tests

* rename get***Id to generate***EntityId

* Update readme & changelog

* OS-593: refactors repo for linting and linting during workflows (#8)

* ci: add linting and fix package manager warnings

* docs: improved pr template

* ci: rename job

* ci: improve commands and workflows

* ci: fix commands

* style: formatting

* build: improved gitignore

* style(OS-593): improves eslint config

Moves linting to the root of the repository and extends this config for
each package

* ci(OS-593): improves linting and testing for subgraph

reconfigures formatting-linting to be callable by other workflows

* ci(OS-593): fix missing dependency installation

fixes missing dependency installation for subgraph during linting

* chore(OS-593): adds missing peerDependecies in subgraph

---------

Co-authored-by: Mathias Scherer <mathias@aragon.org>

* feat: added contracts and tests (#7)

* feat: added contracts, tests, and workflows

* refactor: removed NetworkNameMapping and added base and sepolia support

* ci: improvements

* ci: fix subgraph workflow

* ci: fix contracts workflow

* ci: added contracts subfolder to subgraph workflow triggers

* refactor: improved proxy deployment helpers

* refactor: folder structure

* test: added tests

* style: formatting

* refactor: ProxyFactory and TestGovernanceERC20

* test: add tests for proxy factory

* docs: NatSpec improvments

* test: remove only

* style: fix formatting

* chore: maintained changelog

* chore: added version number and descriptions

* refactor: split helpers into proxy and event

* refactor: revert proxy factory addition

* Terminal chore: maintained changelog  0717be

* refactor: remove unused file

* test: remove only

* ci: removed comments

* refactor: remove redundant line number

* refactor: moved files into governance folder (#10)

* F/os 587 abstract actions and callback ids (#14)

* add action an callbacks id generation

* update changelog

* chore: maintained changelogs (#15)

* chore: maintained changelogs

* chore: revert changes

* feature: abstracted balance and transfer IDs (#12)

* add balance and token ids

* add eslint disable

* fix eslint config

* fix lint

* fix tests

* docs: improved majority voting docs formatting (#16)

* Feature: add id generation for iplugin, iproposal and transactionActionsProposal (#13)

* add id generation for iplugin, iproposal and transactionActionsProposal

* fix prettier

* style: applied prettier formatting

---------

Co-authored-by: Michael Heuer <michael.heuer@rwth-aachen.de>

* Feature: Add js client commons (#11)

* add js client commons

* ci: added test workflow

* add eslintrc

* style: specified included and ignored directories

* style: use similar tsconfig as for contracts and subgraph

* style: removed non-existing folder from tsconfig

* fix eslint

* fix prettier

* test lint

* fix lint

* fix prettier

* test lint

* fix lint

* style: use root level lint command

* build: updated package.json

* style: apply global prettier formatting

* revert typescript version bump

* fix: missing await

* refactor: renamed js-client to sdk

* chore: maintained changelog

* update changelog

* docs: corrected readme title

* Update sdk/README.md

Co-authored-by: Michael Heuer <20623991+Michael-A-Heuer@users.noreply.github.com>

* style: applied prettier formatting

---------

Co-authored-by: Michael Heuer <michael.heuer@rwth-aachen.de>
Co-authored-by: Michael Heuer <20623991+Michael-A-Heuer@users.noreply.github.com>

* fix: wrong contract name (#18)

* chore: added arbitrum support (#17)

* chore: added arbitrum

* chore: add arbiscan api key to example

* chore: added supported networks

* refactor: reduce code-duplication

* fix: typo

* revert: graphql network name change

* fix: Add range test for `bigIntToBytes32`

* fix: remove redundant test

* build(sdk): replaces tsdx with dts-cli (#22)

* feat(sdk): replaces tsdx with dts-cli

* chore(sdk): updates changelog

* style(sdk): applies prettier formatting

* build(sdk): removes tests from tsconfig.json
style(sdk): adds tests into eslint ignore list

* lint(sdk): adds seconds tsconfig to also lint tests and examples

* chore(sdk): fixes prepare script

* style(sdk): makes prettier happy

* ci: adds workflows to release and publish new versions of packages (#24)

* ci(subgraph): adds workflows to release new subgraph packages

* style(subgraph): apply prettier to github action workflows

* Update .github/scripts/generate_release_matrix.py

* ci: adds pull request labeler

* ci(subgraph): finalizes subgraph publish workflow
ci: adds script to generate automatic release notes

* build(subgraph): adds .npmignore file

* chore: applies prettier formatting

* ci: uses subgraph release for all packages

* chore: fix name in packages release workflow

* ci: finishes public and release workflows for all packages

* chore(subgraph): adds EOF newline to .npmignore

* publish(subgraph): replaces .npmignore with package.json config

---------

Co-authored-by: Rekard0 <5880388+Rekard0@users.noreply.github.com>

* build: bump dependencies (#25)

* Feature: Add mock getters (#26)

* add mock getters

* add changelog and fix lint

* remove proposal mocks

* update changelog

* fix prettier

* fix prettier

* Fix: Reusable check tag workflow (#27)

* fix reusable check tag

* fix working directory

* osx-commons-subgraph v0.0.1-alpha.0 (#28)

* release 1.0.0

* update package version

* update changelogs and packages

* fix publish worflow (#29)

* fix package version (#30)

* fix package version

* fix prettier

* release 0.0.1 (#31)

* fix regex pattern in reusable check workflow (#32)

* fix typo (#33)

* Fix: Add missing exports (#35)

* fix exports

* update changelog

* fix lint

* fix tests

* feat(configs): abstract network settings (#34)

* feat(configs): adds supported networks with basic settings
feat(configs): adds all deployments with txhash and block number
feat(configs): initial setup

* feat(configs): adds arbitrum sepolia
feat(configs): removes arbitrum goerli

* feat(configs): updates all networks and contracts

* build(configs): finishes typescript and eslint config

* fix(configs): adds missing erc20 contracts to polygon

* chore(configs): sorts deployments

* feat(config): adds ethers network aliases

* chore(configs): adds linting to workflow

* chore: fixes formatting

* feat(configs): adds baseSepolia deployment

* fix(configs): renames contracts to a proper formatting

* cicd(configs): adds workflow to publish package

* cicd: only run publish on correct tag

* chore(configs): corrects version number

* chore(configs): corrects license

* deps(configs): updates typescript to 5.2.2

* feat(configs): adds aliases for alchemy subgraphs

* cicd(configs): adds it to the reusable-check-tag workflow

* chore(configs): change to cammelcase

* feat(configs): exports networks properly typed with generics (#38)

* cicd(configs): renames publish workflow (#37)

cicd: fixes release not generation

* docs: reference audit files from previous osx versions (#39)

* docs: added audit files from previous osx versions

* refactor: just reference the audit

* docs: improved explanation

* Add: generic entity ID generators (#41)

* add generic functions

* fix lint

* fix operations map

* feat: contracts and sdk refactoring (#36)

* build: added version number to allow importing

* revert: remove osx dependency

* fix: use new IDAO

* feat: add former voting helpers

* feat: refactored helpers

* refactor: event function

* refactor: improved naming

* refactor: improve time helpers

* refactor: removed hardhat time

* fix: wrong import

* refactor: improve time constants

* docs: add todo comment

* refactor: move over plugin and plugin setups as well as permissions

* refactor: renaming and changed folder structure

* feat: added bitmap

* refactor: moved metadata into separate file

* refactor: moved events

* refactor: moved permissions

* revert: version bump of solhint

* refactor: improve folder structure

* refactor: folders structure, imports, yarn lock

* ci: fix

* fix: version mismatch with sdk

* revert: remove etherscan

* refactor: rename event constants

* ci: make sdk an alpha version

* feat: move permissions

* build: rename package

* refactor: structure

* build: save yarn lock

* build: use same typescript version

* refactor: imports

* build: contracts start with alpha version

* build: use commons-sdk

* fix: imports

* build: add files to index

* v0.0.1-alpha.1

* fix: bump version and fix import

* fix: imports

* fix: missing export

* chore: bump version

* chore: save lock file

* chore: bump version

* build: no postinstall

* chore: ignore DS_Store files

* v0.0.1-alpha.3

* refactor: remove proxy helper

* build: add protocol version

* v0.0.1-alpha.4

* feat: made ProtocolVersion non-abstract

* refactor: protocol version number

remove protocol version constant and bump osx-commons-contracts package version number to match with the protocol version

* revert: make ProtocolVersion abstract and use mock instead

* v1.4.0-alpha.1

* refactor: renamed function

* chore: maintain changelog

* build: improve build

* ci: added missing secret

* revert: remove duplicate

* build: remove osx-ethers dependencies

* revert: remove TestPlugin

* build: use files allowlist instead of .npmignore denylist

* refactor: improved mocks

* refactor: improved mocks further

* refactor: rename test

* refactor: remove placeholder setup

* feat: added test sekletons and todos

* revert: removed todo that has its own task already

* build: bump version number

* docs: improved plugin setup mock data

* refactor: renamed PluginMockData to PluginSetupMockData

* refactor: setup mocks

* build: remove src folder

* refactor: move and added todo

* refactor: move auth into dao folder

* build: adapt the hardhat solidity source path subtask

* refactor: move auth

* revert: src removal

* revert: delete storage

* refactor: move governance into extensions

* build: remove governance folder from package.json

* fix: wrong path

* refactor: harmonize mock contract naming and move CloneFactory

* revert: author comment for mock

* style: fix enum values

* feat: add custom event error

* chore: use new sdk

* ci: fixes labeler

---------

Co-authored-by: Mathias Scherer <mathias@aragon.org>

* ci: fixes check tag to ignore semver additions (#42)

* ci: fixes check tag to ignore semver additions

* ci: checktag better fix

* ci: check tag removes useless grep command

* ci: checktag updates comments

* ci: checktag  corrects title

Co-authored-by: Michael Heuer <20623991+Michael-A-Heuer@users.noreply.github.com>

---------

Co-authored-by: Michael Heuer <20623991+Michael-A-Heuer@users.noreply.github.com>

* test: interfaces and ERC-165 (#40)

* build: added version number to allow importing

* revert: remove osx dependency

* fix: use new IDAO

* feat: add former voting helpers

* feat: refactored helpers

* refactor: event function

* refactor: improved naming

* refactor: improve time helpers

* refactor: removed hardhat time

* fix: wrong import

* refactor: improve time constants

* docs: add todo comment

* refactor: move over plugin and plugin setups as well as permissions

* refactor: renaming and changed folder structure

* feat: added bitmap

* refactor: moved metadata into separate file

* refactor: moved events

* refactor: moved permissions

* revert: version bump of solhint

* refactor: improve folder structure

* refactor: folders structure, imports, yarn lock

* ci: fix

* fix: version mismatch with sdk

* revert: remove etherscan

* refactor: rename event constants

* ci: make sdk an alpha version

* feat: move permissions

* build: rename package

* refactor: structure

* build: save yarn lock

* build: use same typescript version

* refactor: imports

* build: contracts start with alpha version

* build: use commons-sdk

* fix: imports

* build: add files to index

* v0.0.1-alpha.1

* fix: bump version and fix import

* fix: imports

* fix: missing export

* chore: bump version

* chore: save lock file

* chore: bump version

* build: no postinstall

* chore: ignore DS_Store files

* v0.0.1-alpha.3

* refactor: remove proxy helper

* build: add protocol version

* v0.0.1-alpha.4

* feat: made ProtocolVersion non-abstract

* refactor: protocol version number

remove protocol version constant and bump osx-commons-contracts package version number to match with the protocol version

* revert: make ProtocolVersion abstract and use mock instead

* v1.4.0-alpha.1

* refactor: renamed function

* chore: maintain changelog

* build: improve build

* ci: added missing secret

* revert: remove duplicate

* build: remove osx-ethers dependencies

* revert: remove TestPlugin

* build: use files allowlist instead of .npmignore denylist

* refactor: improved mocks

* refactor: improved mocks further

* refactor: rename test

* refactor: remove placeholder setup

* feat: added test sekletons and todos

* revert: removed todo that has its own task already

* build: bump version number

* docs: improved plugin setup mock data

* refactor: renamed PluginMockData to PluginSetupMockData

* refactor: setup mocks

* build: remove src folder

* refactor: move and added todo

* refactor: move auth into dao folder

* build: adapt the hardhat solidity source path subtask

* refactor: move auth

* revert: src removal

* revert: delete storage

* refactor: move governance into extensions

* build: remove governance folder from package.json

* fix: wrong path

* refactor: harmonize mock contract naming and move CloneFactory

* revert: author comment for mock

* feat: use name aliases

* feat: added interface related tests

* fix: added missing await

* style: improved linting

* fix: contract linting errors

* style: improve linting

* fix: subgraph linter complaints

* docs: remove todos and add test skeleton

* style: fix enum values

* feat: add custom event error

* chore: use new sdk

* docs: fix comments

* fix: linter

* test: added missing interface test

* test: base classes and free functions (#43)

* build: added version number to allow importing

* revert: remove osx dependency

* fix: use new IDAO

* feat: add former voting helpers

* feat: refactored helpers

* refactor: event function

* refactor: improved naming

* refactor: improve time helpers

* refactor: removed hardhat time

* fix: wrong import

* refactor: improve time constants

* docs: add todo comment

* refactor: move over plugin and plugin setups as well as permissions

* refactor: renaming and changed folder structure

* feat: added bitmap

* refactor: moved metadata into separate file

* refactor: moved events

* refactor: moved permissions

* revert: version bump of solhint

* refactor: improve folder structure

* refactor: folders structure, imports, yarn lock

* ci: fix

* fix: version mismatch with sdk

* revert: remove etherscan

* refactor: rename event constants

* ci: make sdk an alpha version

* feat: move permissions

* build: rename package

* refactor: structure

* build: save yarn lock

* build: use same typescript version

* refactor: imports

* build: contracts start with alpha version

* build: use commons-sdk

* fix: imports

* build: add files to index

* v0.0.1-alpha.1

* fix: bump version and fix import

* fix: imports

* fix: missing export

* chore: bump version

* chore: save lock file

* chore: bump version

* build: no postinstall

* chore: ignore DS_Store files

* v0.0.1-alpha.3

* refactor: remove proxy helper

* build: add protocol version

* v0.0.1-alpha.4

* feat: made ProtocolVersion non-abstract

* refactor: protocol version number

remove protocol version constant and bump osx-commons-contracts package version number to match with the protocol version

* revert: make ProtocolVersion abstract and use mock instead

* v1.4.0-alpha.1

* refactor: renamed function

* chore: maintain changelog

* build: improve build

* ci: added missing secret

* revert: remove duplicate

* build: remove osx-ethers dependencies

* revert: remove TestPlugin

* build: use files allowlist instead of .npmignore denylist

* refactor: improved mocks

* refactor: improved mocks further

* refactor: rename test

* refactor: remove placeholder setup

* feat: added test sekletons and todos

* revert: removed todo that has its own task already

* build: bump version number

* docs: improved plugin setup mock data

* refactor: renamed PluginMockData to PluginSetupMockData

* refactor: setup mocks

* build: remove src folder

* refactor: move and added todo

* refactor: move auth into dao folder

* build: adapt the hardhat solidity source path subtask

* refactor: move auth

* revert: src removal

* revert: delete storage

* refactor: move governance into extensions

* build: remove governance folder from package.json

* fix: wrong path

* refactor: harmonize mock contract naming and move CloneFactory

* revert: author comment for mock

* feat: use name aliases

* feat: added interface related tests

* fix: added missing await

* style: improved linting

* fix: contract linting errors

* style: improve linting

* fix: subgraph linter complaints

* docs: remove todos and add test skeleton

* style: fix enum values

* feat: add custom event error

* chore: use new sdk

* docs: fix comments

* fix: linter

* test: added missing interface test

* test: added Proposal and DAO mock tests

* test: add bitmap tests

* style: fix linters

* style: remove whitespace

* test: remove .only

* test: added more tests

* fix: wrong solcover folder

* revert: remove unused function

* style: satisfy linter

* test: use fixtures and re-use test for upgradeable proposal base class

* test: upgradeability tests

* revert: remove skipped test

uint8 index cannot become larger than 255

* test: DaoAuthorizable contracts

* test: remove duplicated constant

* refactor: corrected naming

* docs: added production warning comment to all mocks

* feat(configs): adds helper function for networks and deployments (#44)

* fix(configs): changes to be commonjs package
feat(configs): improves typings for networks
feat(configs): adds helper function for networks and deployments

* chore(configs): applies formatting

* deploy(configs): bumps version to 0.1.0

* fix(configs): typo in SupportedVerions

* fix(configs): typo in NetworkDeploymnets
docs(configs): adds more clarifying comments

* fix(configs): corrects SupportedVersions enum keys

* Add tests
Add missing sepolia contract
Add NetworksAliases enum
Add CHANGELOG
Add ContractNames enum
Add exported `contracts` object
Add `getNetworkAlias` function

* fix comments

* fix prettier

* fix changelog

* add generic tests

* fix lint
+

* update contract names enum

* update type with enum value

* fix networkDeployment type

---------

Co-authored-by: Jose Manuel Mariñas Bascoy <josemarinasbascoy@gmail.com>

* ci: fixes reusable publish workflow to install deps before trying to publish (#47)

* ci: fixes reusable publish workflow to install deps before trying to publish

* ci(labeler): fixes labeler configuration

* chore: fixes styling in labeler.yml file

* refactor: adaptations to use `osx-commons` in `osx-plugin-template-hardhat` (#48)

* feat: single target permission type

* chore: bump version and maintain changelog

* feat: move more events

* feat: move permission manager flags

* feat: export address constants

* refactor: improved name

* test: moved over tests from hardhat template

* build: added missing import

* build: use the same typescript version

* refactor: address constants

* ci: fixes publish workflows (#50)

* ci: fixes deps installation in publish reuseable

* ci: renames tests workflows names to be more meaningful

* deps(configs): adds tsdlib as dependency

* refactor: `PluginSetup` and deployment helpers (`Proxy`, `CloneFactory`) (#46)

* refactor: deployment helpers and plugin setup

* refactor: enforce setting the implementation through the setup constructor

* chore: maintained changelog

* style: run prettier

* chore: bump package version

* style: run eslint

* fix: wrong variable name

* style: run solhint

* refactor: renaming

* docs: improved natspec

* refactor: added explicit function returning the implementation

* refactor: provide default implementation for the initial build

* build: clean typechain

* refactor: remove default prepareUpdate implementation for the upgradeable setup

* test: setups and deployment helpers

* chore: maintained changelog

* style: fix linting issues

* test: use address constant

* test: initialization

* docs: typo

* refactor: renaming

* style: remove trailing underscore

* style: improve library order

* feat: added event to sdk

* build: use sdk 0.0.1-alpha.5

* build: print coverage report in the console

* test: use fixtures

* fix: linter

* refactor: fix names

* refactor: reverting prepareUpdate default implementation

* style: move fixtures to the end of the files

* revert: remove default implementation

* style: move fixture to the EOF

* Apply suggestions from code review

Co-authored-by: Mathias Scherer <mathias@aragon.org>

---------

Co-authored-by: Mathias Scherer <mathias@aragon.org>

* docs(configs): adds readme for configs package (#49)

* docs(configs): adds readme for configs package

* docs(config): updates readme with small changes

* fix: createWrappedERC20TokenCalls function (#52)

* fix createWrappedERC20TokenCalls

* update package and changelog

* fix: update yarn lock (#53)

* update changelog

* update workflows

* feat: Add missing methods and local network support (#51)

* add missing methods and local network support

* revert getNetworkByNameAliasOrChainId

* fix prettier

* ci: another fix for the labeler

---------

Co-authored-by: Mathias Scherer <mathias@aragon.org>

* feat: add new configs folder structure (#54)

* add new folder structure

* fix prettier

* apply suggestions

* fix prettier

* fix imports

* F/os 1008 fix pr tagging (#59)

* fix pr taging

* fix pr taging

* fix prettier

* labeler test

* labeler test

* update labeler version

* fix prettier

* fix: mocks, missing permission ID, event name removal (#62)

* style: add input variable name

* feat: add ROOT_PERMISSION id

* fix: naming and indentation in mock

* chore: bump package

* revert: remove event names

* CI: remove push contraints for tests (#63)

* ci: remove push contraints for tests

* test: fix failin test in context.test.ts

* feat: improve folder structure for bitmap and events (#56)

* add bitmap and events

* fix prettier

* fix lint

* fix tests

* remove comment

* fix tests

* fix comments

* add error
check anto flipbit and getBit

* fix prettier

* fix comments

* fix: unclear variable naming

* fix: unclear variable naming

* fix: rename contractReceipt to receipt

* fix: errors after rebase

* fix: prettier

* chore: maintained changelog (#64)

* feat: add ens resolving functions (#61)

* add ens resolvers

* updatee changelog

* fix prettier

* add jsdoc

* fix tests

* fix lint and prettier

* fix tests

* update changelog

* fix: grouped 2 functions in one and changed varaible naming on tests

* fix: prettier failing

* fix: provider type and changelog

* update: package version

* feat: define the common domain and the current used exceptions and add getter function for dao ens and plugin ens

* feat: define Network domain type

* ci: move the getters to the getter file

* ci: create a folder for the deployment tests

* feat: add tests for the get dao and plugin functions

* feat: add new deployment test folder to avoid being ignored in the prettierignore

* ci: remove log

* featL update the changelog

* ci: rename types commented in the PR review

* Update configs/src/deployments/types.ts

Co-authored-by: josemarinas <36479864+josemarinas@users.noreply.github.com>

* feat: fix  types issues after using the supported network type

* ci: rename the osx ens domains file

* feat: update the package version

* ci:change to public rpc

* feat: improve folder structure, add hex and plugin folders (#57)

* add hex and plugin folders

* improve JSdoc

* fix prettier

* fix comments

* fix: constant names in tests

* fix: conflicts with develop branch

* feat: add change to changelog and update the package version

* feat: define new rpc urls

* feat: add needed index

* ci: update changelog

* feat: update the hardhat config file to use the common networks

* feat: update the .env.examples

* ci: remove not needed imports

* feat: update the hardhat config to initialize the configuration

* feat: add initializer function to provide the rpc apiKey to the networks configuration

* ci: remove not needed console logs

* feat: move the init function to the network file, and complete the rpc url with the api key

* ci: change the string char

* ci: remove my api key from the env examples

* feat: refactor the hardhat config file

* feat: add commons config to the dependencies

* ci: update the comments in the env example

* feat: remove the rpc url from the networks and add a function to set the value given the rpc and the api key

* feat: update the changelog and the README

* ci: update readme

* ci: remove comment

* feat: update the hardhat config file to use the new addRpcUrlToNetwork from commons-config package

* Chore: Change all RPCs to public RPC (#66)

* ci:change to public rpc

* feat: add change to changelog and update the package version

* feat: define new rpc urls

* feat: add needed index

* ci: update changelog

* feat: add initializer function to provide the rpc apiKey to the networks configuration

* ci: remove not needed console logs

* feat: move the init function to the network file, and complete the rpc url with the api key

* ci: change the string char

* feat: remove the rpc url from the networks and add a function to set the value given the rpc and the api key

* feat: update the changelog and the README

* ci: update readme

* ci: remove comment

* feat: make exception with base goerli when setting the url

---------

Co-authored-by: Claudia <claudiabarcelovaldes40@gmail.com>

* feat: add new commons config version to contracts

* feat: update the workflows to use the new api key

* feat: bump commons config version in sdk package

* feat: update changelog

* f: added more fields to action ID generation and re-organized the structure

* chore: bumped version and updated changelog

* lint: prettier:write

* lint: subgraph linter

* ci: minor update

* feat: define the develop and main branch to run the actions on commits and run them also on PR relevant changes

* ci: fix prettier

* ci: reorder the events

* ci: reorder also in the sdk

* fix: typo in the name of the action event

* Update .github/workflows/sdk-tests.yml

Co-authored-by: Rekard0 <5880388+Rekard0@users.noreply.github.com>

* ci: add new line removed

* chore: remove SDK 1.0 related code from osx-sdk (#72)

* remove: SDK 1.0 unused folders, functions and constants

* update: changelog

* refactor: restructure `osx-commons-sdk` (#73)

* chore: folder restructure

* chore: delete examples from sdk 1.0

* fix: prettier

* fix: broken dependency

* fix: broken dependency

* fix: update yarn.lock

* fix: tests missing dependency

* fix: apply code structure suggestions

* fix: remove regex.ts

* fix: pr comments

* update: package.json version

* feat: bump OZ to v4.9.6 (#74)

* chore: bump OZ

* doc: add item to checklist

* docs: maintained changelog

* chore: bump package version

* feat(sdk): add `getProtocolVersion` function (#76)

* add: getProtocolVersion function

* fix: prettier

* fix: linting

* Update sdk/src/introspection.ts

Co-authored-by: Carles <75954325+banasa44@users.noreply.github.com>

* Update sdk/src/introspection.ts

Co-authored-by: Michael Heuer <20623991+Michael-A-Heuer@users.noreply.github.com>

* Update sdk/test/unit/introspection.test.ts

Co-authored-by: Michael Heuer <20623991+Michael-A-Heuer@users.noreply.github.com>

* remove: constant ADDRESS_ONE

* fix: prettier

* update: changelog and package version

* fix: export of addres one

* fix: update getProtocolVersion return comment

* chore: add ADDRESS_ONE to constants

---------

Co-authored-by: Carles <75954325+banasa44@users.noreply.github.com>
Co-authored-by: Michael Heuer <20623991+Michael-A-Heuer@users.noreply.github.com>

* fix(sdk): `getProtocolVersion` function (#77)

* add: getProtocolVersion function

* fix: prettier

* fix: linting

* Update sdk/src/introspection.ts

Co-authored-by: Carles <75954325+banasa44@users.noreply.github.com>

* Update sdk/src/introspection.ts

Co-authored-by: Michael Heuer <20623991+Michael-A-Heuer@users.noreply.github.com>

* Update sdk/test/unit/introspection.test.ts

Co-authored-by: Michael Heuer <20623991+Michael-A-Heuer@users.noreply.github.com>

* remove: constant ADDRESS_ONE

* fix: prettier

* fix: export of addres one

* fix: update getProtocolVersion return comment

* chore: add ADDRESS_ONE to constants

* feat: add getProtocolVersion

* update pacakge.json

---------

Co-authored-by: Carles <75954325+banasa44@users.noreply.github.com>
Co-authored-by: Michael Heuer <20623991+Michael-A-Heuer@users.noreply.github.com>

* feat(sdk): add back `PluginType` enum and fix npm dependencies (#78)

* feat: add back plugin type enum

* chore: bump version and maintain changelog

* chore: update lockfile

* chore: change authors after AA dissolution (#21)

* chore: adapt authors

* fix: merge conflict artifact

* chore: adapt contracts and bump version (#79)

* docs: added and improved `README.md`s (#80)

* docs: added and improved READMEs

* docs: improved README.md

* style: code snipped formatting

* docs: improved title

* Update README.md

Co-authored-by: Claudia Barcelo <claudiabarcelovaldes40@gmail.com>

---------

Co-authored-by: Claudia Barcelo <claudiabarcelovaldes40@gmail.com>

---------

Co-authored-by: Rekard0 <5880388+Rekard0@users.noreply.github.com>
Co-authored-by: Mathias Scherer <scherer.mat@gmail.com>
Co-authored-by: josemarinas <36479864+josemarinas@users.noreply.github.com>
Co-authored-by: Mathias Scherer <mathias@aragon.org>
Co-authored-by: Jose Manuel Mariñas Bascoy <josemarinasbascoy@gmail.com>
Co-authored-by: Claudia <claudiabarcelovaldes40@gmail.com>
Co-authored-by: jordaniza <jordan.imran@predixa.ai>
Co-authored-by: Jordan <45881807+jordaniza@users.noreply.github.com>
Co-authored-by: Carles <75954325+banasa44@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@banasa44 banasa44 banasa44 left review comments

@heueristik heueristik heueristik approved these changes

@clauBv23 clauBv23 clauBv23 approved these changes

Assignees
No one assigned
Labels
sdk sdk-release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@josemarinas @heueristik @clauBv23 @banasa44