Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add readme and usage guide #23

Merged
merged 1 commit into from
Nov 29, 2023
Merged

docs: add readme and usage guide #23

merged 1 commit into from
Nov 29, 2023

Conversation

heueristik
Copy link
Contributor

@heueristik heueristik commented Nov 28, 2023 •
edited by jira bot
Loading

Task ID: OS-786

@heueristik
Copy link
Contributor Author

Not sure what this file is about packages/subgraph/utils/constants.ts and I asked it also in our internal discord

export const ADDRESS_ZERO = '0x0000000000000000000000000000000000000000';

export const PLUGIN_INTERFACE = '0x11223344';
export const PLUGIN_REPO_ADDRESS = '0xEF30A43458d846bb754DBEE17958Dbc7a7b98618';

What do we need PLUGIN_INTERFACE and PLUGIN_REPO_ADDRESS for and isn't this hard to find and understand for developers @Rekard0 ? Can this be improved in a follow-up task?

@pythonpete32 pythonpete32 merged commit d3af915 into main Nov 29, 2023
3 checks passed
@heueristik heueristik deleted the feature/OS-786-subgraph-readme branch November 29, 2023 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pythonpete32 pythonpete32 pythonpete32 approved these changes

@Rekard0 Rekard0 Awaiting requested review from Rekard0

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@heueristik @pythonpete32