Skip to content
This repository has been archived by the owner on Mar 2, 2020. It is now read-only.

Dot Voting app #5

Closed
stellarmagnet opened this issue May 8, 2019 · 0 comments
Closed

Dot Voting app #5

stellarmagnet opened this issue May 8, 2019 · 0 comments

Comments

@stellarmagnet
Copy link

stellarmagnet commented May 8, 2019

Dot Voting app

Description: Vote on the percentage of funds that distinct entities from an Allocation proposal should receive or on issue curation proposals.

Contract: https://github.com/AutarkLabs/planning-suite/blob/master/apps/dot-voting/contracts/DotVoting.sol

Status: Pending contract changes; expected to be refactored and ready for review by mid to late June.

All of the byte manipulation logic should be handled through a new evmscript executor and a corresponding spec id will be defined. This will allow us to move the byte logic out of DotVoting.sol. In addition DotVoting.sol will need to inherit from IDynamicForwarder or something similar where we can supply logic for performing generalized option composition (extractCandidates) as well as a place to move many of the internal helper functions e.g. substring, gotToParamOffset, _iterateExtraction etc.

Internal Notes: Long term, this contract needs to be updated to leverage evm storage proofs -- once that solution is finalized and adopted for other Aragon apps like Voting.

@LouisGrx LouisGrx added this to New Requests in Security review pipeline May 8, 2019
@LouisGrx LouisGrx moved this from New Requests to AA Prioritization / Review in Security review pipeline May 8, 2019
@LouisGrx LouisGrx moved this from AA Prioritization / Review to External Review in Security review pipeline May 13, 2019
@LouisGrx LouisGrx moved this from External Review to AA Prioritization / Review in Security review pipeline May 13, 2019
@LouisGrx LouisGrx moved this from AA Prioritization / Review to External Review in Security review pipeline May 13, 2019
@LouisGrx LouisGrx moved this from External Review to Audited in Security review pipeline Sep 17, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

No branches or pull requests

2 participants