Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: fix sample code, component import was missing #767

Merged
merged 2 commits into from
May 6, 2020
Merged

Docs: fix sample code, component import was missing #767

merged 2 commits into from
May 6, 2020

Conversation

crisog
Copy link
Contributor

@crisog crisog commented May 5, 2020 •
edited
Loading

On GettingStarted.md, there was a sample code block that was using <Tag>component, but it wasn't being imported.

@welcome
Copy link

welcome bot commented May 5, 2020

Thanks for opening this pull request! Someone will review it soon 🔍

@CLAassistant
Copy link

CLAassistant commented May 5, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@auto-assign auto-assign bot requested a review from bpierre May 5, 2020 22:44
bpierre
bpierre approved these changes May 6, 2020
View reviewed changes
Copy link
Contributor

@bpierre bpierre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, thanks!

@bpierre bpierre merged commit bc35fec into aragon:master May 6, 2020
@welcome
Copy link

welcome bot commented May 6, 2020

Congrats on merging your first pull request! Aragon is proud of you 🦅 Eagle gif

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bpierre bpierre bpierre approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@crisog @CLAassistant @bpierre