Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Frontend for the token-wrapper app #2

Merged
merged 9 commits into from
Oct 16, 2019
Merged

Frontend for the token-wrapper app #2

merged 9 commits into from
Oct 16, 2019

Conversation

theethernaut
Copy link
Contributor

@theethernaut theethernaut commented Oct 10, 2019 •
edited
Loading

This is now working, having tested the following actions:

  • Locking and unlocking tokens from an account, displaying correct token vs wrapped token balances.
  • Being unable to create a vote or vote from an account with no org tokens.
  • Being able to create a vote and vote from an account that has locked tokens and hence has org tokens.

Pls consider that this is my first UI for an app, and I based this work on the guide on hack, so it might not be the way we do things now.

@theethernaut theethernaut requested review from sohkai and removed request for facuspagnuolo October 14, 2019 04:05
sohkai
sohkai approved these changes Oct 14, 2019
View reviewed changes
Copy link
Contributor

@sohkai sohkai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor details, but LGTM!

app/index.html Outdated Show resolved Hide resolved
manifest.json Outdated Show resolved Hide resolved
manifest.json Outdated Show resolved Hide resolved
app/src/abi/ERC20.json Outdated Show resolved Hide resolved
contracts/Template.sol Show resolved Hide resolved
app/src/App.js Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
app/src/script.js Outdated Show resolved Hide resolved
@theethernaut theethernaut mentioned this pull request Oct 16, 2019
Closed
10 tasks
@theethernaut
Copy link
Contributor Author

Thanks for the review @sohkai! All suggestions implemented, merging...

@theethernaut theethernaut merged commit 45ba3fd into master Oct 16, 2019
@theethernaut theethernaut deleted the frontend-proto branch October 16, 2019 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sohkai sohkai sohkai approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@theethernaut @sohkai