More accurate treating of blacklisted links in cluster analyzer

aragozin · Apr 23, 2015 · 859533b · 859533b
1 parent 0eb49a7
commit 859533b
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/hprof-heap/src/main/java/org/gridkit/jvmtool/heapdump/HeapClusterAnalyzer.java b/hprof-heap/src/main/java/org/gridkit/jvmtool/heapdump/HeapClusterAnalyzer.java
@@ -272,6 +272,7 @@ private void walk(Cluster details, Instance i, StringBuilder path, int depth, bo
                 return;
             }
             if (blacklist.contains(i.getJavaClass().getName())) {
+                ignoreRefs.set(i.getInstanceId(), true);
                 return;
             }
             if (details.objects.getAndSet(i.getInstanceId(), true)) {
@@ -366,12 +367,13 @@ private void widthWalk(Cluster details, Instance root, boolean accountShared) {
                     continue;
                 }
 
-                if (details.objects.getAndSet(id, true)) {
+                Instance i = heap.getInstanceByID(id);
+                if (blacklist.contains(i.getJavaClass().getName())) {
+                    ignoreRefs.set(id, true);
                     continue;
                 }
 
-                Instance i = heap.getInstanceByID(id);
-                if (blacklist.contains(i.getJavaClass().getName())) {
+                if (details.objects.getAndSet(id, true)) {
                     continue;
                 }