Stop hardcode alpha offset to 24 for 32-bpp fb. #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For NetBSD/aarch64eb and armeb, framebuffer seems byte-swapped to CPU, which was initially configured to little-endian mode by firmware and switched to big-endian mode by kernel. Therefore, ARGB8888 fb becomes BGRA8888, for example. For Linux and FreeBSD, use alpha offset set by fb drivers. I cannot test them. Sorry. For wscons on NetBSD, unfortunately, alpha offset and size are not set by (most?) fb drivers (they are 0). Therefore, we need to guess them from offsets and sizes of red, green, and blue.
|
Thanks very much! |
|
Thank you for merging the pull request! |
netbsd-srcmastr
pushed a commit
to NetBSD/pkgsrc
that referenced
this pull request
Jan 17, 2022
pkgsrc changes: * switch MASTER_SITES to GitHub * use GTK3 instead of GTK2 * remove local patches integreated into upstream (#5) Upstream changes (noted in doc/en/ReleaseNote): ver 3.9.2 * Support Fcitx5. * Support GTK4 for mlconfig. (./configure --with-gtk=4.0) * Support CSI > Ps q (XTVERSION). (Response: DCS>|mlterm(3.9.2)ST) * Add "MOSH_UDP_PORT" environmental variable to specify UDP port or port-range to communicate with a mosh server. * Add INSERT_CLIPBOARD shortcut key. (arakiken/mlterm#19) * Add --fk / format_other_keys option (equivalent to "formatOtherKeys" of xterm), and change the default format of the escape sequence with modifyOtherKeys from CSI Ps; Ps u to CSI 27; Ps; Ps ~. * Add --with-iconv, --disable-daemon, --disable-split and --disable-zmodem options to ./configure script. * Add vte 0.66 API symbols to libvte compatible library. * Show server list dialog at startup on Android. * It is deprecated to use "mlterm" as the value of termtype / -y option. * 'termcap' config file stops to accept multiple terminal types concated by '|' (e.g. xterm|xterm-256) as key. * Arabic ligatures (U+644-U+622, U+644-U+622, U+644-U+625, U+644-U+627) occupy two logical columns instead of one even if --dyncomb option isn't specified. * KBD_INPUT_NUM and MOUSE_INPUT_NUM environmental variables (for mlterm-fb) accept multiple device numbers by "<num>,<num>". * Show "Config: key=value" only if shortcut keys whose format is "proto:(echo)key=value" is pressed. * Merge patches: arakiken/mlterm#5. arakiken/mlterm#9. arakiken/mlterm#12. arakiken/mlterm#22. * Bug fixes: Fix arakiken/mlterm#15. Fix arakiken/mlterm#18. Fix arakiken/mlterm#24. Fix arakiken/mlterm#28. Fix failure of restarting mlterm on Android. (Enbugged at 3.9.1) Fix segfault if mlterm screen with -t option goes outside of the display. Fix emoji glyphs becoming too large with cairo. Fix corrupt value of "word_separator" option which mlconfig outputs. Fix incompatibility with xterm in pressing Shift + a-z keys etc if modifyOtherKeys is 1. (arakiken/mlterm#21) Fix segfault in opening a new roxterm tab with libvte compatible library on wayland.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For NetBSD/aarch64eb and armeb, framebuffer seems byte-swapped to CPU,
which was initially configured to little-endian mode by firmware and
switched to big-endian mode by kernel. Therefore, ARGB8888 fb becomes
BGRA8888, for example.
For Linux and FreeBSD, use alpha offset set by fb drivers. I cannot
test them. Sorry.
For wscons on NetBSD, unfortunately, alpha offset and size are not
set by (most?) fb drivers (they are 0). Therefore, we need to guess
them from offsets and sizes of red, green, and blue.