Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(conserve): add filter by --tag flag on conserve command #31

Merged
merged 10 commits into from
Oct 4, 2020

Conversation

aramalipoor
Copy link
Owner

@aramalipoor aramalipoor commented Oct 4, 2020

Closes #6

  • Introduce "-t|--tag" flag to narrow down targeted resources (using AWS.ResourceGroupsTaggingAPI)
  • Introduce "prepareTags" step useful for filtering some resources by tag such as DynamoDB
  • Add nock to disable all real network calls in tests

@codecov-commenter
Copy link

codecov-commenter commented Oct 4, 2020

Codecov Report

Merging #31 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##            master       #31    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files           18        18            
  Lines         1193      1343   +150     
  Branches       210       260    +50     
==========================================
+ Hits          1193      1343   +150     
Impacted Files Coverage Δ
src/storage/local.storage.ts 100.00% <ø> (ø)
src/storage/s3.storage.ts 100.00% <ø> (ø)
src/storage/storage.resolver.ts 100.00% <ø> (ø)
src/tricks/trick.registry.ts 100.00% <ø> (ø)
src/base-command.ts 100.00% <100.00%> (ø)
src/commands/conserve.ts 100.00% <100.00%> (ø)
src/commands/restore.ts 100.00% <100.00%> (ø)
...cks/decrease-dynamodb-provisioned-rcu-wcu.trick.ts 100.00% <100.00%> (ø)
...rc/tricks/decrease-kinesis-streams-shards.trick.ts 100.00% <100.00%> (ø)
src/tricks/remove-nat-gateways.trick.ts 100.00% <100.00%> (ø)
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c7826aa...2ab9e5a. Read the comment docs.

@aramalipoor aramalipoor changed the title feat: add filter by --tag flag on conserve command feat(conserve): add filter by --tag flag on conserve command Oct 4, 2020
@aramalipoor aramalipoor merged commit 475142d into master Oct 4, 2020
@aramalipoor aramalipoor deleted the feat/resource-tags branch October 4, 2020 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feature: Allow filtering by tag
2 participants