Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] Fix merge-tsv iotools #1013

Merged
merged 8 commits into from Nov 17, 2023
Merged

[FIX] Fix merge-tsv iotools #1013

merged 8 commits into from Nov 17, 2023

Conversation

NicolasGensollen
Copy link
Member

Closes #1012

@pep8speaks
Copy link

pep8speaks commented Nov 9, 2023 •
edited

Hello @NicolasGensollen! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2023-11-16 11:04:53 UTC

@NicolasGensollen NicolasGensollen marked this pull request as ready for review November 9, 2023 15:51
MatthieuJoulot
MatthieuJoulot approved these changes Nov 13, 2023
View reviewed changes
Copy link
Contributor

@MatthieuJoulot MatthieuJoulot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ! Tested as well, without any issues.

@NicolasGensollen NicolasGensollen merged commit 0eddeb3 into aramis-lab:dev Nov 17, 2023
15 of 19 checks passed
@NicolasGensollen NicolasGensollen deleted the fix-merge-tsv branch November 17, 2023 09:24
@NicolasGensollen NicolasGensollen mentioned this pull request Nov 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MatthieuJoulot MatthieuJoulot MatthieuJoulot approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[IOTOOLS] Regression on clinica iotools merge-tsv
3 participants
@NicolasGensollen @pep8speaks @MatthieuJoulot