New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOC] Improve third-party software documentation page #1099
[DOC] Improve third-party software documentation page #1099
Conversation
@thibaultdvx @MatthieuJoulot if you have some time to take a look at this, I'd be interested to know if you think this is more clear.
|
@NicolasGensollen sure! But do you expect us to follow the whole installation procedure to see if it works, or do you only want comments on the documentation? |
Just comments on whether this way of organizing things feel more clear and practical. Installing all third party software is a lot of work ! 😅 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is much much clearer!
All links and cross-references are working.
I just left two comments.
@@ -19,7 +19,6 @@ You need to process your data with the [`t1-freesurfer` pipeline](../T1_FreeSurf | |||
Do not hesitate to have a look at the paragraph **[Specifying what surface data to use](#advanced-specifying-what-surface-data-to-use)** if you want to use your own surface feature. | |||
|
|||
## Dependencies | |||
<!--If you installed the docker image of Clinica, nothing is required.--> | |||
|
|||
If you only installed the core of Clinica, this pipeline needs the installation of **Matlab** and **FreeSurfer 6.0** on your computer. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You didn't change this dependencies section like the others. Is it normal?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch ! 👍
I didn't change it on purpose because the whole page is totally outdated.
We dropped SurfStat (to use Brainstat instead which is pure Python) more than one year ago but the documentation page was never updated.
There is an issue opened to remember us to do it one day: #980
!!! note | ||
As for Linux, note that using the conda package should be easier in most cases. | ||
|
||
### Matlab |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Matlab is the only software that doesn't have an installation section. Is it ok?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good question.
It was already like this prior to this PR and I'm not sure why this is the case tbh... 🤔
I think Matlab users will have a lot of ways to install it depending on specificities which are way outside of Clinica's scope (maybe your university or institution provides some licenses and custom ways to install it for example).
I think we can keep it like this.
Partly linked to #820, this PR proposes to improve the documentation for the installation of third party softwares.
Instead of having them simply listed in a bullet point list, this PR proposes to have a proper section for each software, with subsections concerning installation steps and configuration steps.
This also changes the explanations about environment variables which were all grouped in a single section.
This could be annoying to users who might only need a subset of them.
With the proposed organization, they only need to define the environment variables described in the configuration section of the software they are interested in.
Finally, this way of organizing things makes it possible to link directly to specific software from pipeline pages instead of linking the third-party page and let the user scroll through it.
In addition, this PR proposes to add documentation about installing and configuring SPM standalone, which was missing from current doc.