[REF] Refactor dependency checking logic for third party softwares #1105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #820
This PR proposes to refactor the checking logic for third party dependencies, especially around SPM which was handled in very complicated ways with lots of code duplication.
This PR also solves the weird environment variable configuration which was required to use SPM standalone.
That is, it removes the need to specify a value for
SPM_HOME. OnlySPMSTANDALONE_HOMEandMCR_HOMEshould be defined and point to the right locations.Finally, this PR adds a lot of unit tests to improve the robustness of these functions.