[MAINT] Missing unit tests for bids_utils #1206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AliceJoubert
force-pushed
the
bids_utils_tests
branch
from
ed354a8
to
4708216
Compare
There was a problem hiding this comment.
Thanks for adding these tests @AliceJoubert !
I just have two very small suggestions, but otherwise the PR LGTM.
|
Thanks for the review @NicolasGensollen ! Do you see anything else ? |
NicolasGensollen
approved these changes
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create a unit test for the function
create_participants_dffrombids_utilsto test before refactoring it. Parametrized only with datasets ADNI, OASIS1 and OASIS3 since the function is only used for ADNI and OASIS1.