Harmonize PET tracers handling (ML / DL / Stats) #137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
get_caps_pet_list function was removed. This function is obsolete (it contained the attempt of defining an analysis-series ID abandoned in 2016-17) and is not used in Clinica. It is likely to be replaced by CAPSTSVBasedInput now.
These functions are obsolete and are replaced by CAPSInputs classes in input.py
Co-authored-by: Ninon Burgos <ninon.burgos@gmail.com>
Co-authored-by: Ninon Burgos <nburgos@users.noreply.github.com>
Co-authored-by: Ninon Burgos <nburgos@users.noreply.github.com>
Co-authored-by: Ninon Burgos <nburgos@users.noreply.github.com>
nburgos
reviewed
Oct 28, 2020
mdiazmel
reviewed
Oct 29, 2020
There was a problem hiding this comment.
Thanks @alexandreroutier,
Code readability has improved a lot with these changes!
A couple suggestions before merging.
Hi! Thanks for the feedback, I addressed the comments in 022b72e :) I think this can now be merged. |
|
Hi @alexandreroutier , |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows PR #129.
After this PR, handling of PET tracers will be the same across Clinica pipelines (
acq_label/suvr_reference_region/ optionaluse_pvc_data).