[FIX] No failure when creation date is not null and other improvements to _check_derived_image_xml
#957
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #955
This PR proposes to improve the function
_check_derived_image_xml
of the ADNI2BIDS converter. This function was performing a bunch of assertions on the metadata associated with derived images. One of these assertions on thecreationDate
field doesn't make sense to me as it was asserting the date is always equal to "0000-00-00":This led to issue #955 were the creation date in the XML file provided by the user is a valid date not equal to this value.
This PR proposes to check that the creation date is either "0000-00-00" or a valid date in format YYYY-MM-DD.
It also changes from assertions to error raising, and tries to improve the error messages to give a better user experience.