Cleaning #564
Merged
Cleaning #564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Thanks @camillebrianceau ! Looking good !
I made a few small suggestions. Feel free to take or leave.
clinicadl/utils/clinica_utils.py
Outdated
| if tracer is not None: | ||
| tracer = Tracer(tracer) | ||
|
|
||
| if modality not in Modality: |
There was a problem hiding this comment.
Because you already did modality = Modality(modality), you know that modality is a valid value. No need to check.
camillebrianceau
added a commit
to camillebrianceau/clinicadl
that referenced
this pull request
May 29, 2024
* first commirt to clean last PR * add enum file + adapt prepare-data
camillebrianceau
added a commit
to camillebrianceau/clinicadl
that referenced
this pull request
May 30, 2024
* first commirt to clean last PR * add enum file + adapt prepare-data
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Next PR : creation of config and adaptation of CLi file for the prepare-data pipeline and addition of unittests