Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

optimize maxAllowedPacket config fix: #292 #281 #297

Merged
merged 1 commit into from
Jul 23, 2022
Merged

optimize maxAllowedPacket config fix: #292 #281 #297

merged 1 commit into from
Jul 23, 2022

Conversation

Penglq
Copy link
Contributor

@Penglq Penglq commented Jul 16, 2022

What this PR does:

Which issue(s) this PR fixes:

Fixes #292 #281

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

@codecov-commenter
Copy link

codecov-commenter commented Jul 16, 2022 •
edited
Loading

Codecov Report

Merging #297 (a0ec56f) into master (29e05f0) will increase coverage by 1.23%.
The diff coverage is 13.27%.

@@            Coverage Diff             @@
##           master     #297      +/-   ##
==========================================
+ Coverage   38.20%   39.44%   +1.23%     
==========================================
  Files          99       99              
  Lines       13618    13716      +98     
==========================================
+ Hits         5203     5410     +207     
+ Misses       7774     7641     -133     
- Partials      641      665      +24
Impacted Files Coverage Δ
pkg/config/model.go 28.97% <0.00%> (-2.99%) ⬇️
pkg/mysql/client.go 32.20% <0.00%> (-3.60%) ⬇️
pkg/mysql/conn.go 39.94% <ø> (ø)
pkg/runtime/runtime.go 2.61% <ø> (ø)
pkg/boot/discovery.go 65.29% <60.00%> (-0.09%) ⬇️
pkg/boot/boot.go 56.16% <63.15%> (+3.78%) ⬆️
pkg/dataset/priority_queue.go 66.30% <0.00%> (-1.09%) ⬇️
pkg/runtime/ast/select_element.go 18.01% <0.00%> (-1.01%) ⬇️
pkg/dataset/group_reduce.go 53.37% <0.00%> (-0.33%) ⬇️
pkg/mysql/utils.go 2.66% <0.00%> (+0.63%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 29e05f0...a0ec56f. Read the comment docs.

@dongzl dongzl added the refactor Refactor code label Jul 17, 2022
georgehao
georgehao reviewed Jul 17, 2022
View reviewed changes
pkg/config/model.go Outdated Show resolved Hide resolved
georgehao
georgehao reviewed Jul 17, 2022
View reviewed changes
pkg/config/model.go Outdated Show resolved Hide resolved
georgehao
georgehao reviewed Jul 17, 2022
View reviewed changes
pkg/config/model.go Outdated Show resolved Hide resolved
pkg/config/model.go Outdated Show resolved Hide resolved
pkg/mysql/client.go Outdated Show resolved Hide resolved
pkg/mysql/client.go Outdated Show resolved Hide resolved
dongzl
dongzl requested changes Jul 17, 2022
View reviewed changes
pkg/config/model.go Outdated Show resolved Hide resolved
pkg/boot/discovery.go Outdated Show resolved Hide resolved
pkg/boot/boot.go Outdated Show resolved Hide resolved
pkg/mysql/client.go Outdated Show resolved Hide resolved
jjeffcaii
jjeffcaii approved these changes Jul 19, 2022
View reviewed changes
Copy link
Contributor

@jjeffcaii jjeffcaii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

dongzl
dongzl requested changes Jul 19, 2022
View reviewed changes
pkg/config/model.go Outdated Show resolved Hide resolved
@dongzl dongzl merged commit 6f5a27d into arana-db:master Jul 23, 2022
binbin0325 pushed a commit to binbin0325/arana that referenced this pull request Jul 26, 2022
@Penglq
optimize maxAllowedPacket config fix: arana-db#292 arana-db#281 (aran…
e5f6cb5 
…a-db#297)
binbin0325 pushed a commit to binbin0325/arana that referenced this pull request Jul 26, 2022
@Penglq
optimize maxAllowedPacket config fix: arana-db#292 arana-db#281 (aran…
10d8c55 
…a-db#297)
dongzl added a commit that referenced this pull request Jul 27, 2022
@chuntaojun @dongzl
@Mulavar @Penglq
Merge master (#320)
0972d5a 
* add unit test. (#306)

* Add: add Range interface mock.

* Add: add test case for iterator.

* fix: format import.

* fix: fix test case error.

* Add: add test case for shard_expr.

* Add: add license header.

* Add: add new test case.

* fix: fix import format.

* refactor schemanager cache to lru cache (#246)

Co-authored-by: Dong Jianhui <dongjianhui03@meituan.com>

* optimize maxAllowedPacket config fix: #292 #281 (#297)

* insert multi value at once request, throw error msg when any row error fix: #287 (#313)

* feat: support show status (#309)

* feat: max_allowed_packet is set by the user (#312)

Co-authored-by: Zonglei Dong <dongzonglei@apache.org>
Co-authored-by: Mulavar <978007503@qq.com>
Co-authored-by: Dong Jianhui <dongjianhui03@meituan.com>
Co-authored-by: adair peng <luqiangpeng5945@gmail.com>
chuntaojun added a commit to chuntaojun/arana that referenced this pull request Jul 27, 2022
@chuntaojun @dongzl
@Mulavar @Penglq
Merge master (arana-db#320)
63c784d 
* add unit test. (arana-db#306)

* Add: add Range interface mock.

* Add: add test case for iterator.

* fix: format import.

* fix: fix test case error.

* Add: add test case for shard_expr.

* Add: add license header.

* Add: add new test case.

* fix: fix import format.

* refactor schemanager cache to lru cache (arana-db#246)

Co-authored-by: Dong Jianhui <dongjianhui03@meituan.com>

* optimize maxAllowedPacket config fix: arana-db#292 arana-db#281 (arana-db#297)

* insert multi value at once request, throw error msg when any row error fix: arana-db#287 (arana-db#313)

* feat: support show status (arana-db#309)

* feat: max_allowed_packet is set by the user (arana-db#312)

Co-authored-by: Zonglei Dong <dongzonglei@apache.org>
Co-authored-by: Mulavar <978007503@qq.com>
Co-authored-by: Dong Jianhui <dongjianhui03@meituan.com>
Co-authored-by: adair peng <luqiangpeng5945@gmail.com>
dongzl added a commit that referenced this pull request Jul 29, 2022
@chuntaojun @jjeffcaii
@dongzl @Mulavar @Penglq
Feature/sequence (#322)
e0d604b 
* [ISSUE #94] Feat sequence (#211)

* feat: support sequence

* feat: none

* feat: snowflake seqneuce finish

* fix: add sequence unit test

* feat: support sequence

* chore: remove test.log

* fix: fix cr issue

* fix: fix integration_test fail

* style: fix code style

* docs: update code comment

* fix: fix pr issue

* fix: fix sql scriip style

* test: add unit test

* docs: fix sql script comment

* refactor: update auto_increment to sequence

* fix: fix cr issue

* refactor: refactor sequence create mgr

* style: fmt code style

* fix: fix pr issue

* docs: fix code comment

* fix: fix cr issue

* fix: fix sequence create table sql (#266)

* fix: compatible with new optimizer structure

* fix ut

* fix: fix sequence bug (#302)

* fix: fix sequence bug

* refactor: use lazy creat sequence

* style: fix code style

* docs: update code comment

* fix: fix pr issue

* fix: remove unuse test file

* Fix new sequence (#316)

* fix: fix sequence bug

* refactor: use lazy creat sequence

* style: fix code style

* docs: update code comment

* fix: fix pr issue

* fix: remove unuse test file

* fix: fix snowflake all even number bug

* Merge master (#320)

* add unit test. (#306)

* Add: add Range interface mock.

* Add: add test case for iterator.

* fix: format import.

* fix: fix test case error.

* Add: add test case for shard_expr.

* Add: add license header.

* Add: add new test case.

* fix: fix import format.

* refactor schemanager cache to lru cache (#246)

Co-authored-by: Dong Jianhui <dongjianhui03@meituan.com>

* optimize maxAllowedPacket config fix: #292 #281 (#297)

* insert multi value at once request, throw error msg when any row error fix: #287 (#313)

* feat: support show status (#309)

* feat: max_allowed_packet is set by the user (#312)

Co-authored-by: Zonglei Dong <dongzonglei@apache.org>
Co-authored-by: Mulavar <978007503@qq.com>
Co-authored-by: Dong Jianhui <dongjianhui03@meituan.com>
Co-authored-by: adair peng <luqiangpeng5945@gmail.com>

* style: fix code style

* ci: fix ci bug

* ci: fix ci bug

* ci: fix ci error

* fix: fix ci bug

* fix: fix runtime.Runtime use

Co-authored-by: Jeffsky <jjeffcaii@outlook.com>
Co-authored-by: Zonglei Dong <dongzonglei@apache.org>
Co-authored-by: Mulavar <978007503@qq.com>
Co-authored-by: Dong Jianhui <dongjianhui03@meituan.com>
Co-authored-by: adair peng <luqiangpeng5945@gmail.com>
binbin0325 pushed a commit to binbin0325/arana that referenced this pull request Jul 31, 2022
@binbin0325
hints fullscan
fdb0977 
* Add: add test case for iterator.

* fix: format import.

* fix: fix test case error.

* Add: add test case for shard_expr.

* Add: add license header.

* Add: add new test case.

* fix: fix import format.

* refactor schemanager cache to lru cache (arana-db#246)

Co-authored-by: Dong Jianhui <dongjianhui03@meituan.com>

* optimize maxAllowedPacket config fix: arana-db#292 arana-db#281 (arana-db#297)

* insert multi value at once request, throw error msg when any row error fix: arana-db#287 (arana-db#313)

* feat: support show status (arana-db#309)

* feat: max_allowed_packet is set by the user (arana-db#312)

Co-authored-by: Zonglei Dong <dongzonglei@apache.org>
Co-authored-by: Mulavar <978007503@qq.com>
Co-authored-by: Dong Jianhui <dongjianhui03@meituan.com>
Co-authored-by: adair peng <luqiangpeng5945@gmail.com>

* style: fix code style

* ci: fix ci bug

* ci: fix ci bug

* ci: fix ci error

* fix: fix ci bug

* fix: fix runtime.Runtime use

Co-authored-by: Jeffsky <jjeffcaii@outlook.com>
Co-authored-by: Zonglei Dong <dongzonglei@apache.org>
Co-authored-by: Mulavar <978007503@qq.com>
Co-authored-by: Dong Jianhui <dongjianhui03@meituan.com>
Co-authored-by: adair peng <luqiangpeng5945@gmail.com>

debug: listen capabilities fix:arana-db#317 (arana-db#328)

feat: support "show collation" SQL statement. (arana-db#307)

chore: add unit test. (arana-db#323)

* Add: add unit test for api.go.

* Add: add license header.

* fix: fix import format.

* fix: refactor mock file directory.

* fix: fix import format.

* fix: fix path name.

* fix: fix test config file content.

* add: add test case for file.go .

* fix: fix import format.

* fix: fix file format.

* fix: fix code review problem.

* fix: fix error test case.

* fix: fix bootstrap test config.

* fix: fix test config data.

commit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjeffcaii jjeffcaii jjeffcaii approved these changes

@dongzl dongzl dongzl approved these changes

@georgehao georgehao georgehao approved these changes

@AlexStocks AlexStocks Awaiting requested review from AlexStocks

@baerwang baerwang Awaiting requested review from baerwang

@blacksmithdqs-ws blacksmithdqs-ws Awaiting requested review from blacksmithdqs-ws

@chuntaojun chuntaojun Awaiting requested review from chuntaojun

@cjphaha cjphaha Awaiting requested review from cjphaha

@conanwang conanwang Awaiting requested review from conanwang

Assignees
No one assigned
Labels
refactor Refactor code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor: Optimize maxAllowedPacket config.
5 participants
@Penglq @codecov-commenter @jjeffcaii @dongzl @georgehao