Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: compatibility with mysql8.0 #450

Merged
merged 1 commit into from
Oct 10, 2022
Merged

Conversation

jjeffcaii
Copy link
Contributor

What this PR does:
fix compatibility with mysql8.0

Which issue(s) this PR fixes:

Fixes #449

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@codecov-commenter
Copy link

codecov-commenter commented Oct 9, 2022

Codecov Report

Base: 35.96% // Head: 35.88% // Decreases project coverage by -0.07% ⚠️

Coverage data is based on head (0bf6e79) compared to base (186a3f8).
Patch coverage: 3.33% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #450      +/-   ##
==========================================
- Coverage   35.96%   35.88%   -0.08%     
==========================================
  Files         124      124              
  Lines       19966    20591     +625     
==========================================
+ Hits         7180     7389     +209     
- Misses      12000    12383     +383     
- Partials      786      819      +33     
Impacted Files Coverage Δ
pkg/boot/discovery.go 53.57% <0.00%> (+10.57%) ⬆️
pkg/config/api.go 80.00% <ø> (ø)
pkg/config/config.go 0.00% <0.00%> (ø)
pkg/config/default.go 96.29% <ø> (+10.58%) ⬆️
pkg/config/diff.go 9.64% <ø> (-0.68%) ⬇️
pkg/config/equals.go 7.69% <ø> (+1.59%) ⬆️
pkg/config/etcd/etcd.go 78.81% <ø> (+5.12%) ⬆️
pkg/config/file/file.go 73.93% <ø> (-0.06%) ⬇️
pkg/config/nacos/nacos.go 41.17% <ø> (+2.56%) ⬆️
pkg/executor/redirect.go 4.54% <ø> (-0.37%) ⬇️
... and 19 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dongzl dongzl added the bug Something isn't working label Oct 9, 2022
@jjeffcaii jjeffcaii merged commit 4068fe9 into arana-db:master Oct 10, 2022
@jjeffcaii jjeffcaii deleted the fix/ISSUE-449 branch October 10, 2022 03:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] java connect arana error.
4 participants