feat: add CAST function placeholder. #474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Wyatt Jia <i@eventloop.live>
Codecov ReportBase: 37.06% // Head: 36.28% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #474 +/- ##
==========================================
- Coverage 37.06% 36.28% -0.78%
==========================================
Files 132 147 +15
Lines 20345 20963 +618
==========================================
+ Hits 7541 7607 +66
- Misses 12002 12524 +522
- Partials 802 832 +30
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Signed-off-by: Wyatt Jia <i@eventloop.live>
dongzl
approved these changes
Oct 26, 2022
dongzl
requested changes
Oct 26, 2022
Signed-off-by: Wyatt Jia <i@eventloop.live>
jjeffcaii
reviewed
Oct 26, 2022
jjeffcaii
reviewed
Oct 26, 2022
jjeffcaii
approved these changes
Oct 26, 2022
Signed-off-by: Wyatt Jia <i@eventloop.live>
dongzl
approved these changes
Nov 7, 2022
Mulavar
approved these changes
Nov 7, 2022
GavinLam164
pushed a commit
to GavinLam164/arana
that referenced
this pull request
Feb 25, 2023
* feat: add CAST function placeholder. Signed-off-by: Wyatt Jia <i@eventloop.live> * format: format import order. Signed-off-by: Wyatt Jia <i@eventloop.live> * format: format code by imports-formatter Signed-off-by: Wyatt Jia <i@eventloop.live> * Remove Cast tdd test case. Signed-off-by: Wyatt Jia <i@eventloop.live> Signed-off-by: Wyatt Jia <i@eventloop.live>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Wyatt Jia i@eventloop.live
What this PR does:
Add
CASTfunction placeholder logic for wholeCASTentrypoints.Which issue(s) this PR fixes:
ref #465
Special notes for your reviewer:
Does this PR introduce a user-facing change?: