Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support MySQL math function PI & TRUNCATE #486

Merged
merged 3 commits into from
Nov 6, 2022

Conversation

PangXing
Copy link
Contributor

@PangXing PangXing commented Nov 5, 2022

What this PR does:
Support MySQL math function PI & TRUNCATE

Which issue(s) this PR fixes:

Fixes #455

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@codecov-commenter
Copy link

codecov-commenter commented Nov 5, 2022

Codecov Report

Base: 36.10% // Head: 35.73% // Decreases project coverage by -0.37% ⚠️

Coverage data is based on head (4219fa2) compared to base (66321cf).
Patch coverage: 50.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #486      +/-   ##
==========================================
- Coverage   36.10%   35.73%   -0.38%     
==========================================
  Files         147      151       +4     
  Lines       21089    21364     +275     
==========================================
+ Hits         7615     7635      +20     
- Misses      12643    12912     +269     
+ Partials      831      817      -14     
Impacted Files Coverage Δ
pkg/runtime/function2/truncate.go 44.00% <44.00%> (ø)
pkg/runtime/function2/pi.go 100.00% <100.00%> (ø)
pkg/boot/discovery_watch.go 3.09% <0.00%> (-21.65%) ⬇️
pkg/boot/boot.go 45.00% <0.00%> (-6.88%) ⬇️
pkg/boot/discovery.go 28.22% <0.00%> (-5.84%) ⬇️
pkg/runtime/ast/show.go 29.55% <0.00%> (-1.12%) ⬇️
pkg/dataset/priority_queue.go 64.35% <0.00%> (-1.00%) ⬇️
pkg/runtime/ast/ast.go 74.37% <0.00%> (-0.12%) ⬇️
pkg/executor/redirect.go 4.91% <0.00%> (-0.03%) ⬇️
pkg/config/tenant.go 0.00% <0.00%> (ø)
... and 3 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dongzl dongzl added the SQL SQL support label Nov 5, 2022
@dongzl dongzl added this to the 0.2.0 milestone Nov 5, 2022
pkg/runtime/function2/pi.go Outdated Show resolved Hide resolved
@AlexStocks AlexStocks merged commit ed79338 into arana-db:master Nov 6, 2022
GavinLam164 pushed a commit to GavinLam164/arana that referenced this pull request Feb 25, 2023
* function PI & TRUNCATE

* function PI & TRUNCATE

* function PI & TRUNCATE
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
SQL SQL support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[SQL] Support MySQL PI and TRUNCATE function.
5 participants