Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat:length #508

Merged
merged 1 commit into from
Nov 13, 2022
Merged

feat:length #508

merged 1 commit into from
Nov 13, 2022

Conversation

baerwang
Copy link
Contributor

What this PR does:

Which issue(s) this PR fixes:

Fixes #502

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@codecov-commenter
Copy link

codecov-commenter commented Nov 13, 2022

Codecov Report

Base: 35.71% // Head: 36.06% // Increases project coverage by +0.34% 🎉

Coverage data is based on head (6270d46) compared to base (b5e3e36).
Patch coverage: 82.35% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #508      +/-   ##
==========================================
+ Coverage   35.71%   36.06%   +0.34%     
==========================================
  Files         157      158       +1     
  Lines       21575    21593      +18     
==========================================
+ Hits         7706     7788      +82     
+ Misses      13055    12959      -96     
- Partials      814      846      +32     
Impacted Files Coverage Δ
pkg/runtime/function2/length.go 82.35% <82.35%> (ø)
pkg/dataset/priority_queue.go 64.35% <0.00%> (-1.00%) ⬇️
pkg/boot/discovery.go 28.33% <0.00%> (+0.11%) ⬆️
pkg/schema/loader.go 6.74% <0.00%> (+1.12%) ⬆️
pkg/boot/boot.go 51.87% <0.00%> (+6.87%) ⬆️
pkg/boot/watcher.go 7.80% <0.00%> (+7.32%) ⬆️
pkg/boot/discovery_watch.go 24.74% <0.00%> (+24.74%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dongzl dongzl added the SQL SQL support label Nov 13, 2022
@dongzl dongzl added this to the 0.2.0 milestone Nov 13, 2022
@jjeffcaii
Copy link
Contributor

PS: add test case for Chinese characters will better, for example: LENGTH('hello世界').

@dongzl dongzl merged commit 7a3ef3a into arana-db:master Nov 13, 2022
GavinLam164 pushed a commit to GavinLam164/arana that referenced this pull request Feb 25, 2023
@baerwang baerwang deleted the feat-length branch June 7, 2024 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
SQL SQL support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[SQL] Support MySQL LENGTH function.
6 participants