Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support Mysql Upper Function #515

Merged
merged 1 commit into from
Nov 16, 2022
Merged

feat: support Mysql Upper Function #515

merged 1 commit into from
Nov 16, 2022

Conversation

raspberry-hu
Copy link
Contributor

What this PR does:

Which issue(s) this PR fixes:

Fixes #513

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@codecov-commenter
Copy link

Codecov Report

Base: 36.26% // Head: 36.28% // Increases project coverage by +0.02% 🎉

Coverage data is based on head (4debee6) compared to base (a586dd0).
Patch coverage: 78.57% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #515      +/-   ##
==========================================
+ Coverage   36.26%   36.28%   +0.02%     
==========================================
  Files         161      162       +1     
  Lines       21722    21736      +14     
==========================================
+ Hits         7877     7887      +10     
- Misses      12984    12987       +3     
- Partials      861      862       +1     
Impacted Files Coverage Δ
pkg/runtime/function2/upper.go 78.57% <78.57%> (ø)
pkg/dataset/priority_queue.go 64.35% <0.00%> (-1.00%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dongzl dongzl added the SQL SQL support label Nov 16, 2022
@dongzl dongzl added this to the 0.2.0 milestone Nov 16, 2022
Copy link
Contributor

@jjeffcaii jjeffcaii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls fix

@jjeffcaii jjeffcaii changed the title feat:Support Mysql Upper Function feat: support Mysql Upper Function Nov 16, 2022
@jjeffcaii jjeffcaii merged commit 36c5419 into arana-db:master Nov 16, 2022
GavinLam164 pushed a commit to GavinLam164/arana that referenced this pull request Feb 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
SQL SQL support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[SQL] Support MySQL UPPER function.
5 participants