Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support MySQL CAST_CHAR function #545

Merged
merged 8 commits into from
Nov 30, 2022
Merged

Support MySQL CAST_CHAR function #545

merged 8 commits into from
Nov 30, 2022

Conversation

csynineyang
Copy link
Contributor

@csynineyang csynineyang commented Nov 23, 2022

What this PR does:

Which issue(s) this PR fixes:

Fixes #484

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@dongzl dongzl added the SQL SQL support label Nov 25, 2022
@dongzl dongzl added this to the 0.2.0 milestone Nov 25, 2022
Copy link
Contributor

@jjeffcaii jjeffcaii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls fix

pkg/runtime/function/cast_char.go Show resolved Hide resolved
pkg/runtime/function/cast_char.go Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Nov 28, 2022

Codecov Report

Base: 35.98% // Head: 36.03% // Increases project coverage by +0.04% 🎉

Coverage data is based on head (fac5028) compared to base (f3c09c9).
Patch coverage: 43.62% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #545      +/-   ##
==========================================
+ Coverage   35.98%   36.03%   +0.04%     
==========================================
  Files         170      171       +1     
  Lines       20989    21135     +146     
==========================================
+ Hits         7553     7615      +62     
- Misses      12631    12703      +72     
- Partials      805      817      +12     
Impacted Files Coverage Δ
pkg/runtime/function/cast_char.go 42.46% <42.46%> (ø)
pkg/runtime/function/cast_nchar.go 57.89% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@AlexStocks AlexStocks merged commit b5e0a21 into arana-db:master Nov 30, 2022
GavinLam164 pushed a commit to GavinLam164/arana that referenced this pull request Feb 25, 2023
* add node config support (arana-db#464)

* Support MySQL CAST_CHAR function.

* format style
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
SQL SQL support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[SQL] Support MySQL CAST_CHAR function.
7 participants