Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle database switch correctly #618

Merged
merged 1 commit into from
Feb 15, 2023

Conversation

jjeffcaii
Copy link
Contributor

What this PR does:

Will handle use <db> correctly.

Which issue(s) this PR fixes:

Fixes #595

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@jjeffcaii jjeffcaii added the bug Something isn't working label Feb 11, 2023
@codecov-commenter
Copy link

codecov-commenter commented Feb 11, 2023

Codecov Report

Base: 36.89% // Head: 37.34% // Increases project coverage by +0.45% 🎉

Coverage data is based on head (d763c7e) compared to base (4bbc3f4).
Patch coverage: 14.52% of modified lines in pull request are covered.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #618      +/-   ##
==========================================
+ Coverage   36.89%   37.34%   +0.45%     
==========================================
  Files         198      198              
  Lines       22141    22773     +632     
==========================================
+ Hits         8168     8505     +337     
- Misses      13065    13338     +273     
- Partials      908      930      +22     
Impacted Files Coverage Δ
pkg/constants/mysql/constants.go 100.00% <ø> (ø)
pkg/mysql/execute_handle.go 0.00% <0.00%> (ø)
pkg/mysql/server.go 0.00% <0.00%> (ø)
pkg/runtime/function/cast_date.go 88.23% <ø> (+0.23%) ⬆️
pkg/runtime/function/cast_time.go 87.61% <ø> (+2.41%) ⬆️
pkg/executor/redirect.go 5.53% <5.00%> (+1.45%) ⬆️
pkg/mysql/conn.go 46.92% <16.66%> (+9.75%) ⬆️
pkg/mysql/client.go 30.73% <50.00%> (ø)
pkg/boot/discovery.go 58.29% <100.00%> (+10.88%) ⬆️
pkg/runtime/function/cast_datetime.go 95.81% <100.00%> (+7.18%) ⬆️
... and 11 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jjeffcaii jjeffcaii force-pushed the fix/ISSUE-595 branch 2 times, most recently from c9bcee8 to e4d2bd1 Compare February 11, 2023 16:53
@dongzl dongzl added this to the 0.2.0 milestone Feb 12, 2023
@dongzl dongzl merged commit 67926e0 into arana-db:master Feb 15, 2023
GavinLam164 pushed a commit to GavinLam164/arana that referenced this pull request Feb 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] use employees error, get dataset error 6: Unknown database 'employees'
5 participants