Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/nacos registry #659

Merged
merged 4 commits into from
Apr 7, 2023
Merged

Conversation

Mulavar
Copy link
Contributor

@Mulavar Mulavar commented Mar 22, 2023

What this PR does:
add nacos registry&discovery

Which issue(s) this PR fixes:

Fixes #534

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@codecov-commenter
Copy link

codecov-commenter commented Mar 22, 2023

Codecov Report

Patch coverage: 66.66% and project coverage change: +0.37 🎉

Comparison is base (e4b196d) 36.67% compared to head (5ac1480) 37.05%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #659      +/-   ##
==========================================
+ Coverage   36.67%   37.05%   +0.37%     
==========================================
  Files         202      205       +3     
  Lines       22484    22437      -47     
==========================================
+ Hits         8247     8313      +66     
+ Misses      13321    13205     -116     
- Partials      916      919       +3     
Impacted Files Coverage Δ
pkg/mysql/server.go 0.00% <ø> (ø)
pkg/config/nacos/nacos.go 63.54% <33.33%> (+3.03%) ⬆️
pkg/util/config/nacos.go 75.55% <75.55%> (ø)

... and 33 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

conf/bootstrap.yaml Outdated Show resolved Hide resolved
example/service_discovery/etcd/main.go Outdated Show resolved Hide resolved
@dongzl dongzl added this to the 0.2.0 milestone Mar 25, 2023
@dongzl dongzl added the config Config center. label Mar 25, 2023
@AlexStocks AlexStocks merged commit 41901cc into arana-db:master Apr 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
config Config center.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[config] Nacos as registry center.
6 participants