-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improvements on tests #12
Conversation
Do you can rebuilding the project, please? The failed of Travis it's so weird :S |
@dorianneto this is the output for your test
Fails when runs on php 5.6 {
"language": "php",
"php": "5.6",
"install": [
"composer self-update",
"composer install"
],
"group": "stable",
"dist": "trusty",
"os": "linux"
} I would like to support Laravel >= 5.2, it requires at least |
@arandilopez It will not be necessary because was a stupid error commited by me :P In the Builder class, specifically on validate method, I setted the same method parameter name for the list() method variable. I'm sorry for this :/ Let's continuos make support to Laravel >= 5.2 because there are many projects that use yet. |
@dorianneto I'm gonna merge it |
I love that Builder. ❤️ thanks |
This PR contains:
I forgot to describe the methods on comments. I'm sorry for this :/