Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simple typos #26

Merged
merged 2 commits into from
Oct 12, 2017
Merged

Simple typos #26

merged 2 commits into from
Oct 12, 2017

Conversation

brunorsantos
Copy link
Contributor

No description provided.

arandilopez
arandilopez requested changes Oct 11, 2017
View reviewed changes
Copy link
Owner

@arandilopez arandilopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, but we only need the word without accents. There is a method that clean accents before comparing words

@brunorsantos
Copy link
Contributor Author

brunorsantos commented Oct 12, 2017 •
edited
Loading

The words with accents already were in the pt-br file before.
I removed all the accents, can you verify now @arandilopez ?
Thanks

arandilopez
arandilopez approved these changes Oct 12, 2017
View reviewed changes
Copy link
Owner

@arandilopez arandilopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeap, thank you.

@arandilopez
Copy link
Owner

Many languages uses different kind of accents, thats why some help us to remove replace accents form incoming input in validation

@arandilopez arandilopez merged commit 9d81841 into arandilopez:master Oct 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arandilopez arandilopez arandilopez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@brunorsantos @arandilopez