Bug-Fix and Refactoring work on resetDeadJobs #10800
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markuspf
force-pushed
the
bug-fix/foxx-mastery-fixfiddle
branch
4 times, most recently
from
19c692b
to
0a9abef
Compare
markuspf
changed the title
markuspf
changed the title
dothebart
approved these changes
Jan 7, 2020
dothebart
reviewed
Jan 8, 2020
dothebart
reviewed
Jan 8, 2020
dothebart
approved these changes
Jan 8, 2020
* Document properly what the function is indended to do * Leave the retry loop if shutting down * Simplify and refactor
markuspf
force-pushed
the
bug-fix/foxx-mastery-fixfiddle
branch
from
0a9abef
to
daeb141
Compare
|
tests green. |
This was referenced Jan 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feels more like a hacky solution to the problem that the retry loop does not quit, even when shutting down; What should really happen is that we only retry on the exceptions that are "acceptable", but for that I have to first find out which ones are.