Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

attempt to pacify clang-1100 #14553

Merged
merged 1 commit into from
Jul 29, 2021
Merged

attempt to pacify clang-1100 #14553

merged 1 commit into from
Jul 29, 2021

Conversation

jsteemann
Copy link
Contributor

@jsteemann jsteemann commented Jul 28, 2021 •
edited
Loading

Scope & Purpose

Devel port: #14554

Attempt to pacify specific clang compiler version. This is just a workaround and may not fix the problem.

  • 💩 Bugfix (requires CHANGELOG entry)

Backports:

  • No backports required

Testing & Verification

  • This change is a trivial rework / code cleanup without any test coverage.

@jsteemann jsteemann added this to the 3.8 milestone Jul 28, 2021
@jsteemann jsteemann requested a review from KVS85 July 28, 2021 16:38
@jsteemann jsteemann mentioned this pull request Jul 28, 2021
Merged
3 tasks
mchacki
mchacki approved these changes Jul 29, 2021
View reviewed changes
Copy link
Member

@mchacki mchacki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I think right now we do not move it at all.
However I do not see a reason why it should not be default movable.
But as this I not required right now I am fine with merging this pr.

@KVS85 KVS85 added 3 Build compiling on targets 3 Packaging Distribution / Packages / Installation 4 MacOSX labels Jul 29, 2021
KVS85
KVS85 reviewed Jul 29, 2021
View reviewed changes
Copy link
Contributor

@KVS85 KVS85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@KVS85 KVS85 merged commit 4e84448 into 3.8 Jul 29, 2021
@KVS85 KVS85 deleted the bug-fix-3.8/pacify-clang-1100 branch July 29, 2021 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KVS85 KVS85 KVS85 left review comments

@mchacki mchacki mchacki approved these changes

Assignees

@jsteemann jsteemann

Labels
3 Build compiling on targets 3 Packaging Distribution / Packages / Installation 4 MacOSX
Projects
None yet
Milestone
3.8
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jsteemann @mchacki @KVS85