experimental: try a container growth factor of 1.5x #14811
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
instead of 2x. we will have to see if this has an impact in our regular performance tests.
goedderz
reviewed
Sep 23, 2021
There was a problem hiding this comment.
I took the time to quickly search for this. folly does this for its fbvector implementation with 1.5 as well, except for smaller capacities, where 2 is used. And what "smaller capacity" means may depend on jemalloc.
This is to exactly match the block sizes of the allocator if possible for small sizes, and start to try and re-use memory for larger sizes.
https://github.com/facebook/folly/blob/master/folly/FBVector.h#L1151
https://github.com/facebook/folly/blob/master/folly/docs/FBVector.md
…erimental-container-growth-factor-1-dot-5
goedderz
approved these changes
Sep 23, 2021
…erimental-container-growth-factor-1-dot-5
jsteemann
commented
Sep 27, 2021
goedderz
reviewed
Sep 28, 2021
Co-authored-by: Tobias Gödderz <tobias@arangodb.com>
…erimental-container-growth-factor-1-dot-5
goedderz
approved these changes
Sep 28, 2021
|
Merging now after 3.9 branch-off... |
jsteemann
deleted the
feature/experimental-container-growth-factor-1-dot-5
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scope & Purpose
Should be merged for 3.10.
As suggest by @goedderz in #14803 (comment):
Experimental: try a container growth factor of 1.5x instead of 2x. We will have to see if this has an impact in our regular performance tests.
If this does not have any measurable or a negative effect on performance, we can simply revert the changes in this PR.
Backports:
Testing & Verification