Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search 183 Add additional tests #15204

Merged
merged 9 commits into from Dec 2, 2021
Merged

Search 183 Add additional tests #15204

merged 9 commits into from Dec 2, 2021

Conversation

MBkkt
Copy link
Contributor

@MBkkt MBkkt commented Nov 24, 2021

Scope & Purpose

(Please describe the changes in this PR for reviewers - mandatory)

  • 馃挬 Bugfix (requires CHANGELOG entry)
  • 馃崟 New feature (requires CHANGELOG entry, feature documentation and release notes)
  • 馃敟 Performance improvement
  • 馃敤 Refactoring/simplification
  • 馃摉 CHANGELOG entry made

Backports:

  • Backport for 3.9: (Please link PR)
  • Backport for 3.8: (Please link PR)
  • Backport for 3.7: (Please link PR)

Related Information

(Please reference tickets / specification / other PRs etc)

  • Docs PR:
  • Enterprise PR:
  • GitHub issue / Jira ticket number:
  • Design document:

Testing & Verification

(Please pick either of the following options)

  • This change is a trivial rework / code cleanup without any test coverage.
  • The behavior in this PR was manually tested
  • This change is already covered by existing tests, such as (please describe tests).
  • This PR adds tests that were used to verify all changes:
    • Added new C++ Unit tests
    • Added new integration tests (e.g. in shell_server / shell_server_aql)
    • Added new resilience tests (only if the feature is impacted by failovers)
  • There are tests in an external testing repository:
  • I ensured this code runs with ASan / TSan or other static verification tools

Link to Jenkins PR run:

Documentation

All new features should be accompanied by corresponding documentation.
Bugs and features should furthermore be documented in the CHANGELOG so that
support, end users, and other developers have a concise overview.

  • Added entry to Release Notes
  • Added a new section in the Manual
  • Added a new section in the HTTP API
  • Added Swagger examples for the HTTP API
  • Updated license information in LICENSES-OTHER-COMPONENTS.md for 3rd party libraries

External contributors / CLA Note

Please note that for legal reasons we require you to sign the Contributor Agreement
before we can accept your pull requests.

arangod/IResearch/IResearchLink.cpp Outdated Show resolved Hide resolved
arangod/IResearch/IResearchLink.cpp Outdated Show resolved Hide resolved
@MBkkt MBkkt force-pushed the feature/search-183 branch 2 times, most recently from 218f5b2 to c2face0 Compare November 25, 2021 10:14
@MBkkt MBkkt requested a review from Dronplane November 25, 2021 10:17
@MBkkt MBkkt force-pushed the feature/search-183 branch 2 times, most recently from daedd17 to cb8947d Compare November 26, 2021 16:12
@MBkkt MBkkt requested a review from a team as a code owner December 1, 2021 13:30
@gnusi gnusi merged commit 78d90df into devel Dec 2, 2021
@gnusi gnusi deleted the feature/search-183 branch December 2, 2021 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants