Chore: Add allProtocols flag and group some tests that run for all protocols #18392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpoeter
force-pushed
the
chore/group-some-tests
branch
from
b5599e2
to
703dc5d
Compare
mpoeter
force-pushed
the
chore/group-some-tests
branch
from
703dc5d
to
4877d83
Compare
dothebart
requested changes
Mar 23, 2023
There was a problem hiding this comment.
we need to have a CLI switch to python setting the serial execution so this can be used in oskar (optionally) as well, and to keep the code more similar.
We also need to disable multi-execution on Mac since we need to cut down on testcoverage on these underpowered machines.
| TestConfig(runner.cfg, name, suite, [*extra_args], 1, 1, []) | ||
| ) | ||
| config = SiteConfig(Path(args.definitions).resolve()) | ||
| config.serialize_execution = True |
There was a problem hiding this comment.
I think for better portability this flag should be set from the CLI as parameter.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scope & Purpose