Feature/license feature v2 #18518
Feature/license feature v2 #18518
Conversation
…ture/license-feature-v2
|
This is the New PR, please ignore old one |
…ture/license-feature-v2
| struct NumberOfCoresCache { | ||
| NumberOfCoresCache(); | ||
| std::atomic<std::size_t> cachedValue; | ||
| std::atomic<bool> overridden; | ||
| }; |
There was a problem hiding this comment.
This class is unimplemented. It is not the same class as NumberOfCoresCache defined in an anonymous namespace in NumberOfCores.cpp. It this declaration used anywhere?
| struct PhysicalMemoryCache { | ||
| PhysicalMemoryCache(); | ||
| std::atomic<uint64_t> cachedValue; | ||
| std::atomic<bool> overridden; | ||
| }; |
There was a problem hiding this comment.
Turns out it is used in the enterprise repository. Calling the constructor of this class will result in a linker error in the community branch.
…ture/license-feature-v2
| @@ -37,6 +37,7 @@ | |||
| #include "ProgramOptions/Parameters.h" | |||
| #include "ProgramOptions/ProgramOptions.h" | |||
| #include "ProgramOptions/Section.h" | |||
| #include "RestServer/RestartAction.h" | |||
| @@ -98,6 +98,23 @@ ArangoGlobalContext::ArangoGlobalContext(int /*argc*/, char* argv[], | |||
| #endif | |||
| #endif | |||
|
|
|||
| bool lastOptionName{false}; | |||
There was a problem hiding this comment.
What is this magic for? What happens if the database directory is not given on the command line? Don't we have a DatabasePathFeature for this?
There was a problem hiding this comment.
I also do not understand the logic with lastOptionName.
There was a problem hiding this comment.
At the very least it deserves an explanation.
|
I have to say that in particular on the last day before a code freeze it is of special importance that all is done such that reviewers have it easy. Contrary to our agreed best practice, this PR:
|
Scope & Purpose
Expand license feature for resources and components
Checklist
Related Information
(Please reference tickets / specification / other PRs etc)