Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove compile option -fno-stack-protector #19464

Closed
wants to merge 2 commits into from
Closed

remove compile option -fno-stack-protector #19464

wants to merge 2 commits into from

Conversation

jsteemann
Copy link
Contributor

@jsteemann jsteemann commented Jul 24, 2023 •
edited
Loading

Scope & Purpose

Removes compile option -fno-stack-protector, which is potentially not needed anymore. This can slightly simplify the build process.
Oskar PR: arangodb/oskar#529
Performance test run: https://jenkins.arangodb.biz/view/Performance/job/perf-simple-branch/97/

  • 💩 Bugfix
  • 🍕 New feature
  • 🔥 Performance improvement
  • 🔨 Refactoring/simplification

Checklist

  • Tests
    • Regression tests
    • C++ Unit tests
    • integration tests
    • resilience tests
  • 📖 CHANGELOG entry made
  • 📚 documentation written (release notes, API changes, ...)
  • Backports
    • Backport for 3.11: -
    • Backport for 3.10: -
    • Backport for 3.9: -

Related Information

  • Docs PR:
  • Enterprise PR:
  • GitHub issue / Jira ticket:
  • Design document:

@jsteemann jsteemann added this to the devel milestone Jul 24, 2023
@cla-bot cla-bot bot added the cla-signed label Jul 24, 2023
@jsteemann jsteemann mentioned this pull request Jul 24, 2023
Closed
@jsteemann jsteemann marked this pull request as ready for review July 25, 2023 08:43
MBkkt
MBkkt reviewed Jul 26, 2023
View reviewed changes
Copy link
Contributor

@MBkkt MBkkt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do you need to run perf tests?
This option specified only for coverage build.
So instead of perf tests you need to run coverage build and check coverage not changed a lot

@jsteemann
Copy link
Contributor Author

Why do you need to run perf tests? This option specified only for coverage build. So instead of perf tests you need to run coverage build and check coverage not changed a lot

This is not true. We also set this option in Oskar when building arangod executables.

@MBkkt
Copy link
Contributor

MBkkt commented Jul 26, 2023

This is not true. We also set this option in Oskar when building arangod executables.

Thanks, I see

@jsteemann jsteemann marked this pull request as draft July 27, 2023 13:36
@jsteemann
Copy link
Contributor Author

Will not be followed-up soon, thus closing.

@jsteemann jsteemann closed this Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MBkkt MBkkt MBkkt left review comments

Assignees
No one assigned
Labels
cla-signed
Projects
None yet
Milestone
devel
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jsteemann @MBkkt