allow to disable fast lock round for transactions #20856
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this is currently an internal option that is only used by a test that validates request lane priorities
maierlars
approved these changes
Apr 22, 2024
…able-fast-lock-round
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scope & Purpose
Allow to disable fast lock round for transactions via setting it in a streaming transaction's options
{"skipFastLockRound":true}. The option defaults to false, so the fast lock round is tried where possible.The
skipFastLockRoundoption is currently for internal use only and is used by a test that validates request lane priorities.It could be made public later in case we want to expose it. Then it also needs to be made available in drivers.
As an aside, this PR also makes some ConnectionPoolTest a bit more robust. It started failed last week in my PR, and I don't think the failures are related to the changes in it.
Checklist
Related Information