Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add fixes for socket shutdown #20877

Merged
merged 33 commits into from
May 13, 2024
Merged

add fixes for socket shutdown #20877

merged 33 commits into from
May 13, 2024

Commits on Apr 30, 2024

  1. Fix SSL connection retry attempts for cluster-internal connections 

    * Fix connection retry attempts for cluster-internal TLS connections that ran
  into the 15 seconds timeout during the connection establishing attempt.
  In this case, the low-level socket was repurposed, but not reset properly.
  This could leave the connection in an improper state and lead to callbacks
  for some requests to not being called as expected.
    @jsteemann
    jsteemann committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    2e9a736 View commit details
    Browse the repository at this point in the history

  2. apply some review comments

    @jsteemann
    jsteemann committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    a219cf6 View commit details
    Browse the repository at this point in the history

  3. check if connection was aborted

    @jsteemann
    jsteemann committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    e3f7279 View commit details
    Browse the repository at this point in the history

  4. revert change to cmakelists for tests

    @jsteemann
    jsteemann committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    71e2b5e View commit details
    Browse the repository at this point in the history

  5. Merge branch '3.11' of github.com:arangodb/arangodb into bug-fix-3.11… 

    …/socket-shutdown
    @jsteemann
    jsteemann committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    92fefa4 View commit details
    Browse the repository at this point in the history

Commits on May 2, 2024

  1. disable socket rearming for now

    @jsteemann
    jsteemann committed May 2, 2024
    Configuration menu
    Copy the full SHA
    b5b50ef View commit details
    Browse the repository at this point in the history

Commits on May 3, 2024

  1. simplify PR

    @jsteemann
    jsteemann committed May 3, 2024
    Configuration menu
    Copy the full SHA
    4b506ff View commit details
    Browse the repository at this point in the history

  2. Merge branch 'bug-fix-3.11/socket-shutdown' of github.com:arangodb/ar… 

    …angodb into bug-fix-3.11/socket-shutdown
    @jsteemann
    jsteemann committed May 3, 2024
    Configuration menu
    Copy the full SHA
    2b4c53d View commit details
    Browse the repository at this point in the history

  3. remove retry entirely

    @jsteemann
    jsteemann committed May 3, 2024
    Configuration menu
    Copy the full SHA
    11928cd View commit details
    Browse the repository at this point in the history

  4. Merge branch '3.11' of github.com:arangodb/arangodb into bug-fix-3.11… 

    …/socket-shutdown
    @jsteemann
    jsteemann committed May 3, 2024
    Configuration menu
    Copy the full SHA
    70f9050 View commit details
    Browse the repository at this point in the history

  5. fix arangosh build

    @jsteemann
    jsteemann committed May 3, 2024
    Configuration menu
    Copy the full SHA
    0b5c67c View commit details
    Browse the repository at this point in the history

  6. Merge branch 'bug-fix-3.11/socket-shutdown' of github.com:arangodb/ar… 

    …angodb into bug-fix-3.11/socket-shutdown
    @jsteemann
    jsteemann committed May 3, 2024
    Configuration menu
    Copy the full SHA
    178c583 View commit details
    Browse the repository at this point in the history

  7. Merge branch '3.11' into bug-fix-3.11/socket-shutdown

    @KVS85
    KVS85 committed May 3, 2024
    Configuration menu
    Copy the full SHA
    243c291 View commit details
    Browse the repository at this point in the history

Commits on May 6, 2024

  1. Merge branch '3.11' of github.com:arangodb/arangodb into bug-fix-3.11… 

    …/socket-shutdown
    @jsteemann
    jsteemann committed May 6, 2024
    Configuration menu
    Copy the full SHA
    11c2730 View commit details
    Browse the repository at this point in the history

  2. further fixes for socket shutdown

    @jsteemann
    jsteemann committed May 6, 2024
    Configuration menu
    Copy the full SHA
    43bf56b View commit details
    Browse the repository at this point in the history

Commits on May 7, 2024

  1. fix ownership issue

    @jsteemann
    jsteemann committed May 7, 2024
    Configuration menu
    Copy the full SHA
    8f7911b View commit details
    Browse the repository at this point in the history

  2. fix compiler warning

    @jsteemann
    jsteemann committed May 7, 2024
    Configuration menu
    Copy the full SHA
    0bc3207 View commit details
    Browse the repository at this point in the history

  3. Merge branch '3.11' into bug-fix-3.11/socket-shutdown

    @jsteemann
    jsteemann committed May 7, 2024
    Configuration menu
    Copy the full SHA
    7a31330 View commit details
    Browse the repository at this point in the history

  4. Merge branch '3.11' of github.com:arangodb/arangodb into bug-fix-3.11… 

    …/socket-shutdown
    @jsteemann
    jsteemann committed May 7, 2024
    Configuration menu
    Copy the full SHA
    3463a1d View commit details
    Browse the repository at this point in the history

  5. simplify PR

    @jsteemann
    jsteemann committed May 7, 2024
    Configuration menu
    Copy the full SHA
    a2706fd View commit details
    Browse the repository at this point in the history

  6. Merge branch 'bug-fix-3.11/socket-shutdown' of github.com:arangodb/ar… 

    …angodb into bug-fix-3.11/socket-shutdown
    @jsteemann
    jsteemann committed May 7, 2024
    Configuration menu
    Copy the full SHA
    75333f6 View commit details
    Browse the repository at this point in the history

  7. reset timer earlier

    @jsteemann
    jsteemann committed May 7, 2024
    Configuration menu
    Copy the full SHA
    7039fa6 View commit details
    Browse the repository at this point in the history

  8. make sure callback is always called

    @jsteemann
    jsteemann committed May 7, 2024
    Configuration menu
    Copy the full SHA
    0981766 View commit details
    Browse the repository at this point in the history

  9. fix timer cancelation race

    @jsteemann
    jsteemann committed May 7, 2024
    Configuration menu
    Copy the full SHA
    a3381d3 View commit details
    Browse the repository at this point in the history

Commits on May 8, 2024

  1. fixes for socket shutdown

    @jsteemann
    jsteemann committed May 8, 2024
    Configuration menu
    Copy the full SHA
    3cf96ff View commit details
    Browse the repository at this point in the history

  2. remove invalid assertion

    @jsteemann
    jsteemann committed May 8, 2024
    Configuration menu
    Copy the full SHA
    5d1da43 View commit details
    Browse the repository at this point in the history

  3. Fix: check if socket is open in connect callback 

    It is possible that the timeout went off right before and has closed the socket before the callback was executed with a success code.
    @mpoeter @jsteemann
    mpoeter authored and jsteemann committed May 8, 2024
    Configuration menu
    Copy the full SHA
    27c383e View commit details
    Browse the repository at this point in the history

  4. fix compilation

    @jsteemann
    jsteemann committed May 8, 2024
    Configuration menu
    Copy the full SHA
    cf2ad97 View commit details
    Browse the repository at this point in the history

  5. add tests

    @jsteemann
    jsteemann committed May 8, 2024
    Configuration menu
    Copy the full SHA
    52a3c69 View commit details
    Browse the repository at this point in the history

Commits on May 10, 2024

  1. Merge branch '3.11' of github.com:arangodb/arangodb into bug-fix-3.11… 

    …/socket-shutdown
    @jsteemann
    jsteemann committed May 10, 2024
    Configuration menu
    Copy the full SHA
    25cbf60 View commit details
    Browse the repository at this point in the history

  2. increase connection timeout

    @jsteemann
    jsteemann committed May 10, 2024
    Configuration menu
    Copy the full SHA
    b8d7d33 View commit details
    Browse the repository at this point in the history

  3. Merge branch '3.11' of github.com:arangodb/arangodb into bug-fix-3.11… 

    …/socket-shutdown
    @jsteemann
    jsteemann committed May 10, 2024
    Configuration menu
    Copy the full SHA
    23bc61d View commit details
    Browse the repository at this point in the history

Commits on May 13, 2024

  1. fix spurious test failure

    @jsteemann
    jsteemann committed May 13, 2024
    Configuration menu
    Copy the full SHA
    9112003 View commit details
    Browse the repository at this point in the history