Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.11] Fix move assignments in boost asio #20899

Merged
merged 1 commit into from
May 6, 2024
Merged

Conversation

mpoeter
Copy link
Member

@mpoeter mpoeter commented May 6, 2024

Scope & Purpose

Fixes two move assignments in boost asio. One that causes an invalid pointer and heap-use-after-free, and one leaking resources.

  • 💩 Bugfix

Checklist

  • Tests
    • Regression tests
    • C++ Unit tests
    • integration tests
    • resilience tests
  • 📖 CHANGELOG entry made
  • 📚 documentation written (release notes, API changes, ...)
  • Backports
    • Backport for 3.12.0: (Please link PR)
    • Backport for 3.11: (Please link PR)
    • Backport for 3.10: (Please link PR)

@mpoeter mpoeter added this to the 3.11 milestone May 6, 2024
@cla-bot cla-bot bot added the cla-signed label May 6, 2024
Copy link
Member

@neunhoef neunhoef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@jsteemann jsteemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@KVS85 KVS85 merged commit 2abd6ae into 3.11 May 6, 2024
2 checks passed
@KVS85 KVS85 deleted the bug-fix-3.11/boost-asio-fixes branch May 6, 2024 15:08
@jsteemann jsteemann mentioned this pull request May 6, 2024
19 tasks
jsteemann pushed a commit that referenced this pull request May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants