remove retry logic for fuerte connections #20906
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix connection retry attempts for cluster-internal TLS connections that ran into the 15 seconds timeout during the connection establishing attempt. In this case, the low-level socket was repurposed, but not reset properly. This could leave the connection in an improper state and lead to callbacks for some requests to not being called as expected.
…angodb into bug-fix-3.11/socket-shutdown
…angodb into bug-fix-3.11/socket-shutdown
mpoeter
approved these changes
May 7, 2024
19 tasks
jsteemann
changed the title
|
We will abandon this solution without retries in favor of a solution with retries (#20877 and the likes). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scope & Purpose
Backport of #20907
into the 15 seconds timeout during the connection establishing attempt.
In this case, the low-level socket was repurposed, but not reset properly.
This could leave the connection in an improper state and lead to callbacks
for some requests to not being called as expected.
The fix is to remove the retry logic, and instead prolong the connection
timeout to a multiple of the previous timeout value.
Checklist
Related Information