Bug fix/default stack size on osx too small #5265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-fix/default-stack-size-on-osx-too-small
…f adjusting the stack size
mchacki
requested changes
May 4, 2018
lib/Basics/threads-posix.cpp
Outdated
| auto err = pthread_attr_init (&stackSizeAttribute); | ||
| if (err) { | ||
| // We should never be here | ||
| TRI_ASSERT(false); |
There was a problem hiding this comment.
Can we add a proper exception here please.
This will fail in our tests, but in delivered versions if it shows up (even if it is super unlikely obviously it is still possible) we will end up in undefined behaviour otherwise.
There was a problem hiding this comment.
Good point. I also considered this as ultra unlikely and
lib/Basics/threads-posix.cpp
Outdated
| err = pthread_attr_getstacksize(&stackSizeAttribute, &stackSize); | ||
| if (err) { | ||
| // We should never be here | ||
| TRI_ASSERT(false); |
There was a problem hiding this comment.
Same here add Proper error handling
lib/Basics/threads-posix.cpp
Outdated
| err = pthread_attr_setstacksize (&stackSizeAttribute, 8388608); | ||
| if (err) { | ||
| // We should never be here | ||
| TRI_ASSERT(false); |
tests/main.cpp
Outdated
| } | ||
| int result() {return result_;} | ||
| private: | ||
| Function f_; |
There was a problem hiding this comment.
i thought our convention for private variables is:
_private
not:
private_
please fix
| std::thread subthread(runTests, argc, argv); | ||
| subthread.join(); | ||
| TestThread<decltype(tests)> t(std::move(tests), argc, argv); | ||
| result = t.result(); |
There was a problem hiding this comment.
Our of curiousity don't we need the join() some where?
I do not see any place waiting for the test to complete. On the old we did wait for the subthread.
There was a problem hiding this comment.
No don't need join. The thread is joined or detatched in destruction of arangodb::Thread.
|
|
Is the error reported by @dothebart sorted out as well? |
|
ok from internal discussion this has been sorted out, was an issue on the machine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OSX default stack size for threads is at 512k, needs tweaking.