Re-Add the now optional method to automatically analyze crashes #5435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* the user or CI may now specify `--coreCheck true` if the testsuite should perform automatic core analysis for him.
…ture/auto-debug-parametrizeable
|
@dothebart : please resolve the merge conflict |
…o-debug-parametrizeable
dhly-etc
suggested changes
Jun 4, 2018
| @@ -82,6 +82,7 @@ let optionsDocumentation = [ | |||
| ' - `prefix`: prefix for the tests in the xml reports', | |||
| '', | |||
| ' - `rr`: if set to true arangod instances are run with rr', | |||
| ' - `coreCheck`: if set to true we will try to locate coredumps and get a backtrace from it', | |||
There was a problem hiding this comment.
"if set to true, we will attempt to locate a coredump to produce a backtrace in the event of a crash"
| @@ -85,7 +85,7 @@ function upgrade (options) { | |||
|
|
|||
| const argv = toArgv(args); | |||
|
|
|||
| result.upgrade.first = pu.executeAndWait(pu.ARANGOD_BIN, argv, options, 'upgrade', tmpDataDir); | |||
| result.upgrade.first = pu.executeAndWait(pu.ARANGOD_BIN, argv, options, 'upgrade', tmpDataDir, options.enableCoreCheck); | |||
There was a problem hiding this comment.
Isn't this options.coreCheck elsewhere?
| @@ -95,7 +95,7 @@ function upgrade (options) { | |||
|
|
|||
| ++result.upgrade.total; | |||
|
|
|||
| result.upgrade.second = pu.executeAndWait(pu.ARANGOD_BIN, argv, options, 'upgrade', tmpDataDir); | |||
| result.upgrade.second = pu.executeAndWait(pu.ARANGOD_BIN, argv, options, 'upgrade', tmpDataDir, options.enableCoreCheck); | |||
There was a problem hiding this comment.
Isn't this options.coreCheck elsewhere?
dhly-etc
approved these changes
Jun 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--coreCheck trueif the testsuiteshould perform automatic core analysis for him.
This eases the process of evaluating crashes on different targets like windows and mac.