Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc - Don't use ditaa anymore #8354

Closed
wants to merge 3 commits into from
Closed

Conversation

Simran-B
Copy link
Contributor

@Simran-B Simran-B commented Mar 8, 2019

It gives you very little control over the style. Creating an equivalent image with GIMP, Inkscape or whatever is more or less the same in effort. ASCII art is nice, but we never really used it.

@Simran-B Simran-B added this to the devel milestone Mar 8, 2019
@Simran-B Simran-B self-assigned this Mar 8, 2019
@ghost ghost added the 2 - Working label Mar 8, 2019
@Simran-B
Copy link
Contributor Author

May fail on checkout because the oskar script does not seem to cover the case of untracked files causing a conflict:
https://github.com/arangodb/oskar/blob/master/scripts/switchBranches.fish

Throwing away local changes by git checkout -- doesn't cut it, because this won't affect untracked files. git reset --hard and git clean -fdx seem to be carried out only if and git checkout "$branch" was successful and clean is set to true. In the else branch, nothing removes untracked files.

A possible solution would be to git checkout --force $branch, perhaps only if clean is set to true.

@Simran-B
Copy link
Contributor Author

Simran-B commented May 6, 2019

Moved to arangodb/docs#12

@Simran-B Simran-B closed this May 6, 2019
@fceller fceller deleted the documentation/ditaa-to-png branch July 30, 2019 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants