-
Notifications
You must be signed in to change notification settings - Fork 831
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve path finder tests #8849
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Move the functions which are used both in ConstantWeightShortestPathFinder and KShortestPathsFinder into GraphTestTools * Don't display spurious error messages when there are multiple options for found paths anymore
mchacki
approved these changes
Apr 29, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ObiWahn
added a commit
that referenced
this pull request
Apr 29, 2019
…-fix/heartbeat-plan-versions * 'devel' of https://github.com/arangodb/arangodb: (22 commits) Improve path finder tests (#8849) fix invalid usage of VPackSlice (#8865) RocksDB returns certain statistics values as strings. honor that fix assertion (#8860) compress-data option for arangodump. ported from 3.4 (#8861) fix race in _batchPingTimer shutdown (#8801) also fsync underlying directory, otherwise data may not reach disk (#8855) escape internal REs (#8857) fix misleading instruction in error message (#8820) Fix tick overflow (#8840) Remove duplicate code (#8825) Avoid some exceptions in environment feature when reading files. (#8834) Create a context for the DocumentProducingFunction callbacks (#8852) Do less copying in HashedCollect (#8850) Feature/aql by line cleanup (#8848) Read docs in EnumerateCollection in batches (#8823) Foxx Security (#8845) Reinclude performance optimization of Return in Subquery (#8844) Remove several tests from greylisting record the times used for the setup/teardown methods of jsunity tests; exposed to the json report file to be enabled along with the junit xml report files. (#8838) ...
ObiWahn
added a commit
that referenced
this pull request
Apr 29, 2019
…ture/cpp17 * 'devel' of https://github.com/arangodb/arangodb: Improve path finder tests (#8849) fix invalid usage of VPackSlice (#8865) RocksDB returns certain statistics values as strings. honor that fix assertion (#8860) compress-data option for arangodump. ported from 3.4 (#8861) fix race in _batchPingTimer shutdown (#8801) also fsync underlying directory, otherwise data may not reach disk (#8855) escape internal REs (#8857) fix misleading instruction in error message (#8820) Fix tick overflow (#8840) Remove duplicate code (#8825) Avoid some exceptions in environment feature when reading files. (#8834)
ObiWahn
added a commit
that referenced
this pull request
Apr 30, 2019
…-fix/foxx-security-windows-symlinks * 'devel' of https://github.com/arangodb/arangodb: fix a few issues in BackupNoAuthSysTest (#8868) track number of failed requests that want to bump the plan version (#8867) next hack attempt (#8802) Improve estimator apply algo + test (#8871) Stream Transaction HTTP docs (#8833) Improve path finder tests (#8849)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and KShortestPathsFinder into GraphTestTools
for found paths anymore