Bug fix/internal issue #566 #9497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is there documentation for the new behaviours / functionality? Anything that needs to be mentioned in UpgradingChanges? |
|
Implementation is backward compatible, e.g. all existing queries utilizing TOKENS functions will behave the same way as before. So, I assume there is nothing to mention in UpgradeChanges? Documentation will be updated with separate PR. |
goedderz
reviewed
Jul 18, 2019
| } else if (current.isBool()) { | ||
| arangodb::iresearch::addStringRef( | ||
| builder, arangodb::basics::StringUtils::encodeBase64(irs::ref_cast<char>( | ||
| irs::boolean_token_stream::value(current.getBoolean())))); |
There was a problem hiding this comment.
I have no idea what this should do. At the very least I've got to see the documentation first.
There was a problem hiding this comment.
This will give us internal analyzer representation for given value, just like with strings
gnusi
suggested changes
Jul 18, 2019
gnusi
approved these changes
Jul 22, 2019
ObiWahn
added a commit
that referenced
this pull request
Jul 23, 2019
…-fix/optimization-of-nested-collect * 'devel' of https://github.com/arangodb/arangodb: fix asan issue (#9540) Docs: Add missing Cookbook placeholder folder Remove documentation, now here: github.com/arangodb/docs (#8918) Revert "Fix name of example graph in k Shortest Paths documentation (#8972)" Docs: Revert more accidental changes fixed an issue with smart joins if both collections were restricted to a (#9535) Remove some minReplicationFactor doc changes, fix indent Bug fix/internal issue #566 (#9497)
ObiWahn
added a commit
that referenced
this pull request
Jul 24, 2019
…ture/one-shard-db * 'devel' of https://github.com/arangodb/arangodb: fix asan issue (#9540) Docs: Add missing Cookbook placeholder folder Remove documentation, now here: github.com/arangodb/docs (#8918) Revert "Fix name of example graph in k Shortest Paths documentation (#8972)" Docs: Revert more accidental changes fixed an issue with smart joins if both collections were restricted to a (#9535) Remove some minReplicationFactor doc changes, fix indent Bug fix/internal issue #566 (#9497)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New behavior for TOKENS function.
Added ability to tokenize numbers, nulls and booleans with corresponding analyzers (terms returned as Base64Encoded)
Analyzer name (second parameter) is now optional (identity used by default)
Added ability to process arrays (possible nested)
Added tests for new functionality (js and GTEST)
https://jenkins.arangodb.biz/view/PR/job/arangodb-matrix-pr/5262/