Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a way to cancel a query after a while (timeout option) #572

Closed
AntoineAA opened this issue Sep 17, 2018 · 8 comments
Closed

Add a way to cancel a query after a while (timeout option) #572

AntoineAA opened this issue Sep 17, 2018 · 8 comments
Labels
ArangoDB Issue concerns ArangoDB, not the driver.

Comments

@AntoineAA
Copy link

AntoineAA commented Sep 17, 2018

In our production environment, we want to prevent requests that are too long to run indefinitely. A timeout option would be very useful for stopping the execution of these queries. Since there is no option on ArangoDB, we have to cancel the query manually from aardvark.

Do you think it would be possible to add a timeout option, at query level, that would do this automatically?

Best,

Antoine

@pluma
Copy link
Contributor

pluma commented Sep 19, 2018

This sounds like something that would need to be implemented in ArangoDB itself. Currently the API only provides a ttl (which is only relevant for the results after the query has executed):
https://docs.arangodb.com/3.3/HTTP/AqlQueryCursor/AccessingCursors.html

Implementing the API for managing queries would help by making it possible to cancel these queries using arangojs but I see no way to easily solve the timeout within arangojs itself. If you want an automatic timeout I'd suggest opening a new issue on the ArangoDB repo: https://github.com/arangodb/arangodb/issues

@pluma pluma added the ArangoDB Issue concerns ArangoDB, not the driver. label Sep 19, 2018
@pluma
Copy link
Contributor

pluma commented Sep 19, 2018

See also #474

@AntoineAA
Copy link
Author

Hi @pluma,
Thanks for your reply!

@AntoineAA
Copy link
Author

We already opened this: arangodb/arangodb#6146

@pluma
Copy link
Contributor

pluma commented Oct 18, 2018

I'm closing this since an issue on the ArangoDB repo exists for this and there's nothing else we can do in arangojs in the meantime. Feel free to reopen when the option is supported by ArangoDB.

@pluma pluma closed this as completed Oct 18, 2018
@AntoineAA
Copy link
Author

@pluma OK, thanks!

@Puneeth-Kadamba
Copy link

When is the issue addressed on ArangoDB repo?. Do we have any ETA for the same?

@pluma
Copy link
Contributor

pluma commented Dec 3, 2018

@Puneeth-Kadamba Please check the issue on the ArangoDB repo linked above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ArangoDB Issue concerns ArangoDB, not the driver.
Projects
None yet
Development

No branches or pull requests

3 participants