Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix assignment response.host to task.host #604

Closed
wants to merge 1 commit into from
Closed

Fix assignment response.host to task.host #604

wants to merge 1 commit into from

Conversation

roboncode
Copy link

The assignment to response.host throws an error because host is a getter. This looks to be a typo given everywhere else the assignment is to task.host. Before the fix, the error thrown was:

TypeError: Cannot set property host of # which has only a getter
at _hosts.(anonymous function) (/Users/rob/Projects/RobOnCode/totaljs-example/node_modules/arangojs/lib/async/connection.js:130:35)
at IncomingMessage.res.on (/Users/rob/Projects/RobOnCode/totaljs-example/node_modules/arangojs/lib/async/util/request.node.js:78:21)
at IncomingMessage.emit (events.js:185:15)
at endReadableNT (_stream_readable.js:1106:12)
at process._tickCallback (internal/process/next_tick.js:178:19)

@OmarAyo
Copy link

OmarAyo commented Apr 26, 2019

Hi @roboncode

Many thanks for contributing. We are obliged by law to have a signed scanned copy of a Contributor License Agreement (CLA) to be able to accept pull requests to the official ArangoDB repository - even for such small changes.

We use an Apache 2 CLA for ArangoDB and its companion projects, which can be found here: https://www.arangodb.com/documents/cla.pdf
Just fill in the form, sign and send a scanned copy over to cla@arangodb.com

Thank you

@pluma pluma closed this in bb9a337 Aug 27, 2019
@pluma
Copy link
Contributor

pluma commented Aug 27, 2019

Upon closer investigation, the code was correct but the name host was already in use in some Node environments. To avoid conflicts the name has been changed to something more unique.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants