This repository has been archived by the owner on Dec 13, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 59
DOC-36 | JavaScript API for Stream Transactions #1070
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neunhoef
approved these changes
Aug 10, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I think you have chosen to call the transactions "stream transactions" as opposed to "streaming transactions", that seems to be consistent. All fine. I had one comment where I suggested to warn earlier about transaction timeouts and size limitations.
…s at 2022-08-03T10:37:01+00:00" This reverts commit 30c04a4.
…2-08-12T11:39:41+00:00
ansoboleva
approved these changes
Aug 12, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reviewed
Simran-B
added a commit
that referenced
this pull request
Aug 18, 2022
* WIP * WIP * WIP * Fix links * Improve example * Fix example * Minor tweaks * Apply to 3.8 and 3.9 * Update transactions-stream-transactions.md * Update examples for 3.8,3.9,3.10 in js-api-stream-transactions at 2022-08-03T10:37:01+00:00 * Apply review changes to 3.8 and 3.9 * Remove misleading statement * Remove misleading statement * Remove misleading statement * Revert "Update examples for 3.8,3.9,3.10 in js-api-stream-transactions at 2022-08-03T10:37:01+00:00" This reverts commit 30c04a4. * Update examples for 3.8,3.9,3.10 in js-api-stream-transactions at 2022-08-12T11:39:41+00:00 Co-authored-by: ansoboleva <93702078+ansoboleva@users.noreply.github.com> Co-authored-by: arangodb-release-bot <anastasia.soboleva@arangodb.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add description of JS API to v3.8+. Partially addresses DOC-56, too (separate JavaScript and Stream Transaction pages in Manual).
Examples need to be re-generated.