Skip to content
This repository has been archived by the owner on Dec 13, 2023. It is now read-only.

DOC-36 | JavaScript API for Stream Transactions #1070

Merged
merged 19 commits into from
Aug 12, 2022

Conversation

Simran-B
Copy link
Collaborator

@Simran-B Simran-B commented Jul 21, 2022

Add description of JS API to v3.8+. Partially addresses DOC-56, too (separate JavaScript and Stream Transaction pages in Manual).

Examples need to be re-generated.

@Simran-B Simran-B self-assigned this Jul 21, 2022
@Simran-B Simran-B marked this pull request as ready for review July 31, 2022 17:33
Copy link
Member

@neunhoef neunhoef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I think you have chosen to call the transactions "stream transactions" as opposed to "streaming transactions", that seems to be consistent. All fine. I had one comment where I suggested to warn earlier about transaction timeouts and size limitations.

3.10/transactions.md Outdated Show resolved Hide resolved
3.10/transactions.md Show resolved Hide resolved
Copy link
Collaborator

@ansoboleva ansoboleva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed

@ansoboleva ansoboleva merged commit 0c9c0f3 into main Aug 12, 2022
@ansoboleva ansoboleva deleted the js-api-stream-transactions branch August 12, 2022 12:29
Simran-B added a commit that referenced this pull request Aug 18, 2022
* WIP

* WIP

* WIP

* Fix links

* Improve example

* Fix example

* Minor tweaks

* Apply to 3.8 and 3.9

* Update transactions-stream-transactions.md

* Update examples for 3.8,3.9,3.10 in js-api-stream-transactions at 2022-08-03T10:37:01+00:00

* Apply review changes to 3.8 and 3.9

* Remove misleading statement

* Remove misleading statement

* Remove misleading statement

* Revert "Update examples for 3.8,3.9,3.10 in js-api-stream-transactions at 2022-08-03T10:37:01+00:00"

This reverts commit 30c04a4.

* Update examples for 3.8,3.9,3.10 in js-api-stream-transactions at 2022-08-12T11:39:41+00:00

Co-authored-by: ansoboleva <93702078+ansoboleva@users.noreply.github.com>
Co-authored-by: arangodb-release-bot <anastasia.soboleva@arangodb.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants